mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	2nddept-manager@sdl.hitachi.co.jp,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 4/9] tracing/kprobes: Cleanup strict_strtol() using code
Date: Mon,  7 Feb 2011 13:00:07 -0200	[thread overview]
Message-ID: <1297090812-10782-5-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1297090812-10782-1-git-send-email-acme@infradead.org>

From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Since strict_strtol() accepts minus digits started with '-', it doesn't
need to invert after converting.

Cc: 2nddept-manager@sdl.hitachi.co.jp
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20110204125153.9507.49335.stgit@ltc236.sdl.hitachi.co.jp>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 kernel/trace/trace_kprobe.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 2dec9bc..2088893 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -767,16 +767,15 @@ static int __parse_probe_arg(char *arg, const struct fetch_type *t,
 		}
 		break;
 	case '+':	/* deref memory */
+		arg++;	/* Skip '+', because strict_strtol() rejects it. */
 	case '-':
 		tmp = strchr(arg, '(');
 		if (!tmp)
 			break;
 		*tmp = '\0';
-		ret = strict_strtol(arg + 1, 0, &offset);
+		ret = strict_strtol(arg, 0, &offset);
 		if (ret)
 			break;
-		if (arg[0] == '-')
-			offset = -offset;
 		arg = tmp + 1;
 		tmp = strrchr(arg, ')');
 		if (tmp) {
-- 
1.6.2.5


  parent reply	other threads:[~2011-02-07 15:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 15:00 [PATCH 0/9] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 1/9] perf tools: Makefile: Use $(QUIET_GEN) for perf.so Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 2/9] perf top: Use pid_t for target_{pid|tid} Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 3/9] perf probe: Rewrite find_lazy_match_lines() by using getline(3) Arnaldo Carvalho de Melo
2011-02-07 15:00 ` Arnaldo Carvalho de Melo [this message]
2011-02-07 15:00 ` [PATCH 5/9] tracing/kprobes: Support longer (>128 bytes) command Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 6/9] tracing/kprobes: Add bitfield type Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 7/9] perf probe: Add bitfield member support Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 8/9] perf tool: Fix gcc 4.6.0 issues Arnaldo Carvalho de Melo
2011-02-07 15:00 ` [PATCH 9/9] perf annotate: Fix build error Arnaldo Carvalho de Melo
2011-02-07 15:06 ` [PATCH 0/9] perf/core improvements and fixes Ingo Molnar
2011-02-07 16:29   ` Arnaldo Carvalho de Melo
2011-02-07 17:36     ` Arnaldo Carvalho de Melo
2011-02-08  1:05       ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297090812-10782-5-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=2nddept-manager@sdl.hitachi.co.jp \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®