From: James Bottomley <James.Bottomley@suse.de>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: make scsi_devinfo infrastructure optional
Date: Thu, 10 Feb 2011 09:07:36 -0600 [thread overview]
Message-ID: <1297350456.4933.25.camel@mulgrave.site> (raw)
In-Reply-To: <AANLkTimE1H=hos+YMW3Ge9vkETC9f1k1Dt6AMi5iLHGW@mail.gmail.com>
On Thu, 2011-02-10 at 10:18 +0100, Bartlomiej Zolnierkiewicz wrote:
> On Wed, Feb 9, 2011 at 7:00 PM, James Bottomley <James.Bottomley@suse.de> wrote:
> > On Wed, 2011-02-09 at 15:15 +0100, Bartlomiej Zolnierkiewicz wrote:
> >> Add SCSI_QUIRKS config option (default y and dependent on EMBEDDED
> >> config option) to allow disabling of scsi_devinfo infrastructure.
> >>
> >> The output code size savings are ~14k for CONFIG_SCSI_QUIRKS=n
> >> (as measured on x86-32):
> >
> > I don't understand the point of this patch ... without the quirks SCSI
> > will do the wrong thing on a whole bunch of stuff. The savings look to
> > be tiny ... since the SCSI module is habitually a lot larger than your
> > figures suggest.
>
> The patch was originally done for embedded ATA-only setups.
Well, if it's for ATA only then the better course would be extracting
libata from scsi. It's also a bit misleading to do sizings on x86,
because that doesn't imply embedded to me. Aren't there still ATAPI
devices that require the quirks?
Most embedded setups include some form of USB ... again, the pluggable
CD/DVD use the quirks table.
Given the potential for disaster even on embedded systems, I don't
really think something like this is a good idea.
James
next prev parent reply other threads:[~2011-02-10 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 14:15 Bartlomiej Zolnierkiewicz
2011-02-09 18:00 ` James Bottomley
2011-02-10 9:18 ` Bartlomiej Zolnierkiewicz
2011-02-10 15:07 ` James Bottomley [this message]
2011-02-11 9:52 ` Bartlomiej Zolnierkiewicz
2011-02-11 16:06 ` James Bottomley
2011-02-12 12:16 ` Bartlomiej Zolnierkiewicz
2011-02-12 20:54 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297350456.4933.25.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=bzolnier@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome