From: James Bottomley <James.Bottomley@suse.de>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
mark gross <markgross@thegnar.org>,
David Alan Gilbert <linux@treblig.org>,
linux-kernel@vger.kernel.org, Len <len.brown@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [Patch] idle governor: Avoid lock acquisition to read pm_qos before entering idle
Date: Fri, 11 Feb 2011 13:33:34 -0600 [thread overview]
Message-ID: <1297452814.4967.110.camel@mulgrave.site> (raw)
In-Reply-To: <1297452478.2645.265.camel@schen9-DESK>
On Fri, 2011-02-11 at 11:27 -0800, Tim Chen wrote:
> On Fri, 2011-02-11 at 20:22 +0100, Rafael J. Wysocki wrote:
>
> >
> > Thanks, but I'd put that comment before the structure definition with the
> > "NOTE:" prefix and I think you should explain the reason why that field
> > shouldn't be changed to 64-bits.
> >
>
> Either you or James want to suggest a comment on why the field shouldn't
> be changed to 64-bits to be placed there?
/*
* Note: The lockless read read path depends on the CPU accessing
* target_value atomically. Atomic access is only guaranteed on all CPU
* types linux supports for 32 bit quantites
*/
James
next prev parent reply other threads:[~2011-02-11 19:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 1:21 Tim Chen
2011-02-10 3:46 ` Andi Kleen
2011-02-10 18:59 ` Rafael J. Wysocki
2011-02-10 5:10 ` mark gross
2011-02-10 16:20 ` Andi Kleen
2011-02-10 17:27 ` Tim Chen
2011-02-10 17:45 ` James Bottomley
2011-02-10 18:50 ` Rafael J. Wysocki
2011-02-10 19:33 ` Tim Chen
2011-02-10 20:37 ` James Bottomley
2011-02-10 17:55 ` mark gross
2011-02-10 23:17 ` Rafael J. Wysocki
2011-02-11 0:50 ` Tim Chen
2011-02-11 19:22 ` Rafael J. Wysocki
2011-02-11 19:27 ` Tim Chen
2011-02-11 19:33 ` James Bottomley [this message]
2011-02-11 20:03 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297452814.4967.110.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linux@treblig.org \
--cc=markgross@thegnar.org \
--cc=rjw@sisk.pl \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®