From: Peter Tyser <ptyser@xes-inc.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, Alek Du <alek.du@intel.com>,
Samuel Ortiz <sameo@linux.intel.com>,
David Brownell <dbrownell@users.sourceforge.net>,
Eric Miao <eric.y.miao@gmail.com>,
Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH 1/3] gpiolib: Add ability to get GPIO pin direction
Date: Mon, 14 Feb 2011 12:46:03 -0600 [thread overview]
Message-ID: <1297709163.965.5858.camel@petert> (raw)
In-Reply-To: <AANLkTin7gBNBXKCuwL6Az+-+KQEw8Hsq-DYYr1RTXhFm@mail.gmail.com>
On Mon, 2011-02-14 at 11:04 -0700, Grant Likely wrote:
> On Mon, Feb 14, 2011 at 10:45 AM, Peter Tyser <ptyser@xes-inc.com> wrote:
> >> > We need four states for a gpio pin direction though. A pin can be
> >> >
> >> > - input
> >> > - output
> >>
> >> There are actually multiple output modes that a specific gpio
> >> controller could implement, but the gpio api only has a boolean
> >> understanding of output. I don't know if it is really worthwhile to
> >> try and encode all the possible configurations in this API.
> >>
> >> > - unknown (hardware lacks get functionality and it has not been set by
> >> > software yet)
> >
> > I'm not sure how we could handle unknown directions in a better way. We
> > really should know the direction by this point for most (all?) GPIO
> > chips. I'd think the proper fix would be to make sure we can detect a
> > direction for all chips - either by reading hardware bits or by having
> > the platform code let us know (eg pdata->n_latch in pcf857x.c). If you
> > have a suggestion about how unknown pins should be used, I can look into
> > it and submit a follow up patch.
>
> Does it really matter? Sure it's *nice* to have the current status
> information if the driver can easily get it, but it probably isn't
> critical. Any user of the pin should be putting the pin in the mode
> it needs regardless of the initial state.
I don't think it matters too much since I haven't encountered a driver
where you can't determine a pin direction yet. But if it were
impossible to determine a direction, it would throw people off. They'd
have to know that the pin direction couldn't be trusted initially, which
is a big leap (this is the bug I'm trying to fix with this patch). Eg
if someone sees a pin direction as "input" via sysfs, what are the odds
that they'll run "echo input > direction" just to make sure...
Anyway, I don't think its a critical issue either since its a corner
case with an easy workaround. If we did want to add support for
allowing a direction of "unknown", it could be in a follow up patch
since its technically a bigger issue than this patch.
Peter
next prev parent reply other threads:[~2011-02-14 18:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 19:54 Peter Tyser
2011-01-06 19:54 ` [PATCH 2/3] gpio: pca953x: Implement get_direction() hook Peter Tyser
2011-01-06 23:16 ` David Brownell
2011-01-06 19:54 ` [PATCH 3/3] gpio: Add support for Intel ICHx/3100/Series[56] GPIO Peter Tyser
2011-01-06 23:12 ` David Brownell
2011-02-14 15:48 ` [PATCH 1/3] gpiolib: Add ability to get GPIO pin direction Peter Tyser
2011-02-14 16:02 ` Grant Likely
2011-02-14 19:14 ` Grant Likely
2011-02-14 20:01 ` Peter Tyser
2011-02-14 17:08 ` Alan Cox
2011-02-14 17:26 ` Grant Likely
2011-02-14 17:39 ` Mark Brown
2011-02-14 17:45 ` Peter Tyser
2011-02-14 18:04 ` Grant Likely
2011-02-14 18:46 ` Peter Tyser [this message]
2011-02-14 19:35 ` Alan Cox
2011-02-14 23:35 ` Peter Tyser
2011-02-15 11:42 ` Alan Cox
2011-02-15 17:05 ` Peter Tyser
2011-02-15 17:19 ` Alan Cox
2011-02-15 17:49 ` Peter Tyser
2011-02-15 19:41 ` Alan Cox
2011-02-17 8:06 ` Uwe Kleine-König
2011-03-06 7:53 ` Grant Likely
2011-02-15 23:55 ` Mark Brown
2011-03-06 7:49 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297709163.965.5858.camel@petert \
--to=ptyser@xes-inc.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alek.du@intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbrownell@users.sourceforge.net \
--cc=eric.y.miao@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®