From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Kenneth Albanowski (Palm GBU)" <Kenneth.Albanowski@palm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Jakub Jelinek <jakub@redhat.com>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: Question about clearing of tsk->robust_list in clone
Date: Tue, 15 Feb 2011 15:00:50 +0100 [thread overview]
Message-ID: <1297778450.2413.11.camel@twins> (raw)
In-Reply-To: <alpine.LFD.2.00.1102151233330.26192@localhost6.localdomain6>
On Tue, 2011-02-15 at 14:16 +0100, Thomas Gleixner wrote:
>
> And I do not buy the argument about "complex glibc code" at all. glibc
> already handles it for pthread_create() so why the hell can't it
> handle it for fork() ?
Going by comment #9 they think calling sys_set_robust_list() on every
fork() is too expensive for them, but realistically we cannot do
anything about it, ->robust_list is strictly task state.
I also think their suggestion in comment #11 (lazy state) is flawed,
what if the parent never users robust futexes, in that case the state
will indicate not to initialize the robust state for its children, again
leading to the observed wreckage.
Realistically libpthread should register an on_fork() callback to ensure
the state is properly propagated.
next prev parent reply other threads:[~2011-02-15 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 6:43 Kenneth Albanowski (Palm GBU)
2011-02-15 13:16 ` Thomas Gleixner
2011-02-15 14:00 ` Peter Zijlstra [this message]
2011-02-15 14:19 ` Thomas Gleixner
2011-02-15 22:51 ` Kenneth Albanowski (Palm GBU)
2011-02-15 23:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297778450.2413.11.camel@twins \
--to=peterz@infradead.org \
--cc=Kenneth.Albanowski@palm.com \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwab@linux-m68k.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®