From: Joe Perches <joe@perches.com>
To: Harry Wei <jiaweiwei.xiyou@gmail.com>
Cc: davem@davemloft.net, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, greg@kroah.com,
rdunlap@xenotime.net, pavel@ucw.cz
Subject: Re: [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses
Date: Sun, 20 Feb 2011 08:00:22 -0800 [thread overview]
Message-ID: <1298217622.7179.93.camel@Joe-Laptop> (raw)
In-Reply-To: <20110220135918.GB1972@gmail.com>
On Sun, 2011-02-20 at 21:59 +0800, Harry Wei wrote:
> On Sat, Feb 19, 2011 at 08:46:54PM -0800, Joe Perches wrote:
> > Add quotes around email address with periods and commas.
> Hmm, what about some other conditions except
> for periods and commas in maintainers' M:.
> Like following:
> 1> Character '-' in M:
Dashes are not an issue.
> 2> No name of the M:
> M: support@lsi.com
Names and angle brackets are optional.
> 3> Messy code in M:
> M: Benoît Cousson <b-cousson@ti.com>
8 bit characters _might_ be an issue, but
no one has reported any problems yet.
I think you should read and understand rfc 2822
before continuing with this.
Utilities like git send-email and get_maintainer.pl
generally provide email address parsing for only a
subset of all valid address styles.
As these utilities are done mostly by regex, not
all valid email addresses are supported because the
regex validations get ridiculously complicated.
There are some "monster" regex classes that attempt
to support a greater range of valid email address
styles, but the pain of implementation generally
isn't worth it.
You're free to try to improve it of course, but I
think that modifications to the address styles
currently used in MAINTAINERS to remove "special"
address style handling isn't necessary.
next prev parent reply other threads:[~2011-02-20 16:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 2:51 [PATCH]move double quotation marks so that keep MAINTAINERS consistent Harry Wei
2011-02-10 3:05 ` Greg KH
[not found] ` <AANLkTi=vV7xeeodvfEj_GV_7RO+Kp3WBpf9YRLLAPCBY@mail.gmail.com>
2011-02-10 3:16 ` Fwd: " Harry Wei
2011-02-10 3:06 ` Andrew Morton
2011-02-10 3:17 ` David Miller
2011-02-19 16:48 ` Pavel Machek
2011-02-19 21:59 ` Joe Perches
[not found] ` <AANLkTi=DbJUFfKA9EMnaUm89Fk2OEDWo64-Lu5H8Yjjv@mail.gmail.com>
2011-02-20 2:48 ` Fwd: " Harry Wei
2011-02-20 4:46 ` [PATCH] MAINTAINERS: Quote non-alphanumeric email addresses Joe Perches
2011-02-20 13:20 ` Harry Wei
2011-02-20 13:59 ` Harry Wei
2011-02-20 16:00 ` Joe Perches [this message]
[not found] ` <AANLkTi=qeg6jUBY-D68EW3bK_6EZRrXBE+JRj6GO92v2@mail.gmail.com>
2011-02-21 5:07 ` Fwd: " Harry Wei
2011-02-22 9:28 ` [PATCH]move double quotation marks so that keep MAINTAINERS consistent Florian Mickler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298217622.7179.93.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jiaweiwei.xiyou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome