mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: linux-kernel@vger.kernel.org
Subject: snd_intel8x0m: error message because return value is unused?
Date: Tue, 22 Feb 2011 00:57:22 +0100	[thread overview]
Message-ID: <1298332643.11571.21.camel@t41.thuisdomein> (raw)

0) In order to make a laptop run without error messages (ie, printks at
KERN_ERR level) I had to look at an error generated by snd_intel8x0m:

     ALSA intel8x0m.c:904: AC'97 warm reset still in progress? [0x2]

1) There's a datasheet one can study to understand that message. But
that seems not necessary here. It all boils down to the fact that this
test:

    if ((igetdword(chip, ICHREG(GLOB_CNT)) & ICH_AC97WARM) == 0)
            goto __ok;

will always fail so we'll never go to __ok and finally that error will
be printed. But if I simply change it into:

    cnt = igetdword(chip, ICHREG(GLOB_CNT));
    if ((cnt & ICH_AC97WARM) == 0)
            goto __ok;

this test will (always) succeed, we'll go to __ok and no error message
will be printed. So apparently, the error message was just a false
alarm.

2) Before I submit a (trivial) patch to fix this I'd like to better
understand what is going on here: is this standard C behavior, something
the build system asks the compiler to do, or maybe something else?


Paul Bolle


                 reply	other threads:[~2011-02-21 23:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298332643.11571.21.camel@t41.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®