From: Lars-Peter Clausen <lars@metafoo.de>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Pali Rohar <pali.rohar@gmail.com>,
Rodolfo Giometti <giometti@linux.it>,
Grazvydas Ignotas <notasas@gmail.com>,
linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v3 16/16] bq27x00: Use single i2c_transfer call for property read
Date: Tue, 22 Feb 2011 07:38:01 +0100 [thread overview]
Message-ID: <1298356681-8317-17-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1298356681-8317-1-git-send-email-lars@metafoo.de>
From: Grazvydas Ignotas <notasas@gmail.com>
Doing this by using 2 calls sometimes results in unexpected
values being returned on OMAP3 i2c controller.
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/power/bq27x00_battery.c | 27 +++++++++++----------------
1 files changed, 11 insertions(+), 16 deletions(-)
diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
index 740a0ac..59e68db 100644
--- a/drivers/power/bq27x00_battery.c
+++ b/drivers/power/bq27x00_battery.c
@@ -565,31 +565,26 @@ static DEFINE_MUTEX(battery_mutex);
static int bq27x00_read_i2c(struct bq27x00_device_info *di, u8 reg, bool single)
{
struct i2c_client *client = to_i2c_client(di->dev);
- struct i2c_msg msg;
+ struct i2c_msg msg[2];
unsigned char data[2];
int ret;
if (!client->adapter)
return -ENODEV;
- msg.addr = client->addr;
- msg.flags = 0;
- msg.len = 1;
- msg.buf = data;
-
- data[0] = reg;
- ret = i2c_transfer(client->adapter, &msg, 1);
-
- if (ret < 0)
- return ret;
-
+ msg[0].addr = client->addr;
+ msg[0].flags = 0;
+ msg[0].buf = ®
+ msg[0].len = sizeof(reg);
+ msg[1].addr = client->addr;
+ msg[1].flags = I2C_M_RD;
+ msg[1].buf = data;
if (single)
- msg.len = 1;
+ msg[1].len = 1;
else
- msg.len = 2;
+ msg[1].len = 2;
- msg.flags = I2C_M_RD;
- ret = i2c_transfer(client->adapter, &msg, 1);
+ ret = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg));
if (ret < 0)
return ret;
--
1.7.2.3
next prev parent reply other threads:[~2011-02-22 6:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 6:37 [PATCH v3 00/16] bq27x00: New Properties, fixes, bq27000 support Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 01/16] power_supply: Ignore -ENODATA errors when generating uevents Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 02/16] power_suply: Initialize changed_work before calling device_add Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 03/16] bq27x00: Add type property Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 04/16] bq27x00: Improve temperature property precession Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 05/16] bq27x00: Fix CURRENT_NOW property Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 06/16] bq27x00: Return -ENODEV for properties if the battery is not present Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 07/16] bq27x00: Prepare code for addition of bq27000 platform driver Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 08/16] bq27x00: Add bq27000 support Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 09/16] bq27x00: Cache battery registers Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 10/16] bq27x00: Poll battery state Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 11/16] bq27x00: Add new properties Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 12/16] bq27x00: Add MODULE_DEVICE_TABLE Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 13/16] bq27x00: Give more specific reports on battery status Lars-Peter Clausen
2011-02-22 6:37 ` [PATCH v3 14/16] bq27x00: Minor cleanups Lars-Peter Clausen
2011-02-22 6:38 ` [PATCH v3 15/16] bq27x00: Cleanup bq27x00_i2c_read Lars-Peter Clausen
2011-02-22 6:38 ` Lars-Peter Clausen [this message]
2011-02-22 9:45 ` [PATCH v3 00/16] bq27x00: New Properties, fixes, bq27000 support Anton Vorontsov
2011-02-22 10:07 ` Lars-Peter Clausen
2011-02-28 14:38 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298356681-8317-17-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=cbouatmailru@gmail.com \
--cc=giometti@linux.it \
--cc=linux-kernel@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome