From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751771Ab1BVTwn (ORCPT ); Tue, 22 Feb 2011 14:52:43 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:36708 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717Ab1BVTwl (ORCPT ); Tue, 22 Feb 2011 14:52:41 -0500 X-Authority-Analysis: v=1.1 cv=dquaJDitHqzHCdqWSoZ6IgapSuTzW/4TaRYx9N9k4W8= c=1 sm=0 a=b8VkJ_G4jssA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=meVymXHHAAAA:8 a=pGLkceISAAAA:8 a=JarWaZbUt8hDu0CuQqwA:9 a=eCLDxAW2kLqXyuqNbTGiZtBWYj0A:4 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=MSl-tDqOz04A:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [PATCH] rt2x00: Use ops name instead of device name From: Steven Rostedt To: Ivo Van Doorn Cc: Ben Hutchings , LKML , netdev , Felix Fietkau , "John W. Linville" , abogani@texware.it In-Reply-To: References: <1298380368.6140.1193.camel@gandalf.stny.rr.com> <1298381695.2211.486.camel@localhost> <1298382263.6140.1196.camel@gandalf.stny.rr.com> Content-Type: text/plain; charset="ISO-8859-15" Date: Tue, 22 Feb 2011 14:52:38 -0500 Message-ID: <1298404358.7666.5.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-02-22 at 20:33 +0100, Ivo Van Doorn wrote: > Hi, > > On Tue, Feb 22, 2011 at 2:44 PM, Steven Rostedt wrote: > > On Tue, 2011-02-22 at 13:34 +0000, Ben Hutchings wrote: > > > >> > 19: 73474106 0 IO-APIC-fasteoi ata_piix, uhci_hcd:usb6, 0000:05:01.0 > > > >> > rt2x00dev->irq = pci_dev->irq; > >> > - rt2x00dev->name = pci_name(pci_dev); > >> > + rt2x00dev->name = ops->name; > > > > > >> But then how can users distinguish the IRQs for multiple devices handled > >> by the same driver? (Probably unusual for WLAN devices, but still > >> possible.) > >> > >> I assume you can't use a net device name as there may be multiple net > >> devices per bus device? > > > > Honestly, I do not know this code well enough, but this patch seemed to > > solve the problem at hand. Hence I sent it out to the experts hoping > > they either take this patch or come up with a proper solution ;) > > > > In any case, just posting the pci address is not a pretty answer. > > I just checked the other wireless drivers, and they all seem to use > the modulename. So I guess your patch is correct. You can add my: > > Acked-by: Ivo van Doorn Thanks! Actually, to answer Ben's question. lspci should give you what you want. On my local box (not the one mentioned above): $ lspci -vv [...] 00:0a.0 Bridge: nVidia Corporation CK804 Ethernet Controller (rev a3) Subsystem: Tyan Computer Tomcat K8E (S2865) Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- SERR- Kernel driver in use: forcedeth (spaces added by me) $ cat /proc/interrupts [...] 23: 547 648564 IO-APIC-fasteoi ohci_hcd:usb2, eth0 -- Steve