From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>,
akpm@linux-foundation.org, Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [cpuops cmpxchg double V3 3/5] Generic support for this_cpu_cmpxchg_double
Date: Fri, 25 Feb 2011 15:53:42 -0500 [thread overview]
Message-ID: <1298667222.6376.23.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102251443500.7359@router.home>
On Fri, 2011-02-25 at 14:44 -0600, Christoph Lameter wrote:
> On Fri, 25 Feb 2011, Steven Rostedt wrote:
>
> > > + VM_BUG_ON((unsigned long)(&pcp1) % (2 * sizeof(pcp1))); \
> > > + VM_BUG_ON((unsigned long)(&pcp2) != (unsigned long)(&pcp1) + sizeof(pcp1));\
> > > + VM_BUG_ON(sizeof(pcp1) != sizeof(pcp2)); \
> >
> > Since this is a macro, and it looks like all these are constants (sizeof
> > and addresses), couldn't you just do a BUILD_BUG_ON() instead?
>
> The addresses are not constant.
I was thinking that if these are per_cpu then they would be global and
thus constant. But those are done at link time, which is too late.
OK, nevermind ;)
-- Steve
next prev parent reply other threads:[~2011-02-25 20:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-25 17:38 [cpuops cmpxchg double V3 0/5] this_cpu_cmpxchg_double support Christoph Lameter
2011-02-25 17:38 ` [cpuops cmpxchg double V3 1/5] slub: min_partial needs to be in first cacheline Christoph Lameter
2011-02-25 17:38 ` [cpuops cmpxchg double V3 2/5] slub: Get rid of slab_free_hook_irq() Christoph Lameter
2011-02-25 18:23 ` Mathieu Desnoyers
2011-02-25 17:38 ` [cpuops cmpxchg double V3 3/5] Generic support for this_cpu_cmpxchg_double Christoph Lameter
2011-02-25 18:25 ` Mathieu Desnoyers
2011-02-25 20:28 ` Steven Rostedt
2011-02-25 20:44 ` Christoph Lameter
2011-02-25 20:53 ` Steven Rostedt [this message]
2011-02-25 20:58 ` Christoph Lameter
2011-02-25 21:01 ` Steven Rostedt
2011-02-28 10:22 ` [PATCH] percpu: Generic support for this_cpu_cmpxchg_double() this_cpu_cmpxchg_double Tejun Heo
2011-02-25 17:38 ` [cpuops cmpxchg double V3 4/5] Lockless (and preemptless) fastpaths for slub Christoph Lameter
2011-02-25 18:21 ` Mathieu Desnoyers
2011-02-25 20:46 ` Christoph Lameter
2011-02-25 20:56 ` Mathieu Desnoyers
2011-02-25 17:38 ` [cpuops cmpxchg double V3 5/5] x86: this_cpu_cmpxchg_double() support Christoph Lameter
2011-02-28 10:23 ` [PATCH] percpu, x86: Add arch-specific " Tejun Heo
2011-02-28 10:36 ` [cpuops cmpxchg double V3 0/5] this_cpu_cmpxchg_double support Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298667222.6376.23.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=penberg@cs.helsinki.fi \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®