mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Jean Delvare <khali@linux-fr.org>,
	Jonathan Cameron <kernel@jic23.retrosnub.co.uk>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Greg Schnorr <gschnorr@cisco.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] hwmon: (pmbus) Add support for Maxim MAX16064
Date: Fri, 25 Feb 2011 13:42:44 -0800	[thread overview]
Message-ID: <1298670164.1735.108.camel@groeck-laptop> (raw)
In-Reply-To: <4D681091.4030008@cam.ac.uk>

Hi Jonathan,

On Fri, 2011-02-25 at 15:26 -0500, Jonathan Cameron wrote:
> Again, straight forward use of pmbus_core.  Is it actually worth having
> separate modules for each of these special cases?  Could just do the
> old big table of fixed chip info structures in a single driver...
> 
This is actually what I had originally. My reasoning to split it up was
that this makes it easier to add support for additional chips without
having to modify the core driver. Also, I can keep chip specific code
(specifically the _identify and _get_status functions) out of the core
driver.

Thanks,
Guenter



  reply	other threads:[~2011-02-25 21:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17 19:00 [PATCH v4 0/5] hwmon: PMBus device driver Guenter Roeck
2011-02-17 19:00 ` [PATCH v4 1/5] " Guenter Roeck
2011-02-25 20:23   ` Jonathan Cameron
2011-02-26  2:45     ` Guenter Roeck
2011-02-26 10:41       ` Jonathan Cameron
2011-02-26 15:19         ` Guenter Roeck
2011-02-17 19:00 ` [PATCH v4 2/5] hwmon: (pmbus) Add support for Maxim MAX8688 Guenter Roeck
2011-02-25 20:24   ` Jonathan Cameron
2011-02-25 21:46     ` Guenter Roeck
2011-02-17 19:00 ` [PATCH v4 3/5] hwmon: (pmbus) Add support for Maxim MAX16064 Guenter Roeck
2011-02-25 20:26   ` Jonathan Cameron
2011-02-25 21:42     ` Guenter Roeck [this message]
2011-02-17 19:00 ` [PATCH v4 4/5] hwmon: (pmbus) Add support for Maxim MAX34440/MAX34441 Guenter Roeck
2011-02-25 20:42   ` Jonathan Cameron
2011-02-25 21:32     ` Guenter Roeck
2011-02-26 10:43       ` Jonathan Cameron
2011-02-26 15:21         ` Guenter Roeck
2011-02-17 19:00 ` [PATCH v4 5/5] hwmon: pmbus driver documentation Guenter Roeck
2011-02-25 20:45   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298670164.1735.108.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=gschnorr@cisco.com \
    --cc=jic23@cam.ac.uk \
    --cc=kernel@jic23.retrosnub.co.uk \
    --cc=khali@linux-fr.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®