From: "Koul, Vinod" <vinod.koul@intel.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
"Wang, Qi" <qi.wang@intel.com>,
"toshiharu-linux@dsn.okisemi.com"
<toshiharu-linux@dsn.okisemi.com>,
"Ewe, Kok Howg" <kok.howg.ewe@intel.com>,
"Clark, Joel" <joel.clark@intel.com>
Subject: Re: [PATCH 2/2] pch_dma: set the number of array correctly
Date: Sat, 26 Feb 2011 20:23:49 +0530 [thread overview]
Message-ID: <1298732029.6974.13.camel@vkoul-udesk3> (raw)
In-Reply-To: <BD1B47087D5E7D44AE5A1EFDFBF0023B086D6C222B@bgsmsx502.gar.corp.intel.com>
On Fri, 2011-02-18 at 22:44 +0530, Koul, Vinod wrote:
> > On Fri, 2011-02-18 at 10:01 +0530, Tomoya MORINAGA wrote:
> > set the number of array correctly.
> >
> > Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
> > ---
> > drivers/dma/pch_dma.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> > index bf2ddd6..b1dfba7 100644
> > --- a/drivers/dma/pch_dma.c
> > +++ b/drivers/dma/pch_dma.c
> > @@ -82,7 +82,7 @@ struct pch_dma_regs {
> > u32 dma_sts1;
> > u32 reserved2;
> > u32 reserved3;
> > - struct pch_dma_desc_regs desc[0];
> > + struct pch_dma_desc_regs desc[MAX_CHAN_NR];
> > };
> >
> > struct pch_dma_desc {
> > @@ -124,7 +124,7 @@ struct pch_dma {
> > struct pci_pool *pool;
> > struct pch_dma_regs regs;
> > struct pch_dma_desc_regs ch_regs[MAX_CHAN_NR];
> > - struct pch_dma_chan channels[0];
> > + struct pch_dma_chan channels[MAX_CHAN_NR];
> > };
> >
> > #define PCH_DMA_CTL0 0x00
>
> Both
> Acked-by: Vinod Koul <vinod.koul@intel.com>
Applied both @git://git.infradead.org/users/vkoul/slave-dma.git
Fixed one minor style error in 2nd patch but from next time please
ensure you run checkpatch before sending
--
~Vinod
next parent reply other threads:[~2011-02-26 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BD1B47087D5E7D44AE5A1EFDFBF0023B086D6C222B@bgsmsx502.gar.corp.intel.com>
2011-02-26 14:53 ` Koul, Vinod [this message]
2011-02-28 5:42 ` Tomoya MORINAGA
2011-02-28 16:29 ` Koul, Vinod
2011-02-18 4:31 [PATCH 1/2] pch_dma: fix kernel error issue Tomoya MORINAGA
2011-02-18 4:31 ` [PATCH 2/2] pch_dma: set the number of array correctly Tomoya MORINAGA
2011-02-18 16:26 ` Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298732029.6974.13.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®