mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manohar Vanga <manohar.vanga@cern.ch>
To: <martyn.welch@ge.com>
Cc: <gregkh@suse.de>, <julia@diku.dk>, <cota@braap.org>,
	<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
	Manohar Vanga <manohar.vanga@cern.ch>
Subject: [PATCH 1/1] staging: vme: remove unreachable code
Date: Sun, 27 Feb 2011 00:15:35 +0100	[thread overview]
Message-ID: <1298762135-8752-2-git-send-email-manohar.vanga@cern.ch> (raw)
In-Reply-To: <1298762135-8752-1-git-send-email-manohar.vanga@cern.ch>

Remove some more unreachable code found in bridges/vme_ca91cx42.c
and bridges/vme_tsi148.c

Signed-off-by: Manohar Vanga <manohar.vanga@cern.ch>
---
 drivers/staging/vme/bridges/vme_ca91cx42.c |    3 ---
 drivers/staging/vme/bridges/vme_tsi148.c   |    2 --
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
index 42de83e..5d734d9 100644
--- a/drivers/staging/vme/bridges/vme_ca91cx42.c
+++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
@@ -560,8 +560,6 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
 
 	return 0;
 
-	iounmap(image->kern_base);
-	image->kern_base = NULL;
 err_remap:
 	release_resource(&image->bus_resource);
 err_resource:
@@ -1782,7 +1780,6 @@ static int ca91cx42_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 
 	return 0;
 
-	vme_unregister_bridge(ca91cx42_bridge);
 err_reg:
 	ca91cx42_crcsr_exit(ca91cx42_bridge, pdev);
 err_lm:
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c
index 26ea42f..2df19ea 100644
--- a/drivers/staging/vme/bridges/vme_tsi148.c
+++ b/drivers/staging/vme/bridges/vme_tsi148.c
@@ -869,8 +869,6 @@ static int tsi148_alloc_resource(struct vme_master_resource *image,
 
 	return 0;
 
-	iounmap(image->kern_base);
-	image->kern_base = NULL;
 err_remap:
 	release_resource(&image->bus_resource);
 err_resource:
-- 
1.7.1


  reply	other threads:[~2011-02-26 23:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-26 23:15 [PATCH 0/1] staging: vme: remove some more " Manohar Vanga
2011-02-26 23:15 ` Manohar Vanga [this message]
2011-03-01 15:35   ` [PATCH 1/1] staging: vme: remove " Martyn Welch
  -- strict thread matches above, loose matches on Subject: below --
2011-02-26 22:36 [PATCH 0/1] " Manohar Vanga
2011-02-26 22:36 ` [PATCH 1/1] " Manohar Vanga
2011-03-01 15:34   ` Martyn Welch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298762135-8752-2-git-send-email-manohar.vanga@cern.ch \
    --to=manohar.vanga@cern.ch \
    --cc=cota@braap.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martyn.welch@ge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®