From: Ludwig Nussel <ludwig.nussel@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Ludwig Nussel <ludwig.nussel@suse.de>,
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86
ARCHITECTURE...),
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...),
"H. Peter Anvin" <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...),
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Subject: [PATCH] fix mmap random address range on x86 (try2)
Date: Mon, 28 Feb 2011 15:53:03 +0100 [thread overview]
Message-ID: <1298904783-4291-1-git-send-email-ludwig.nussel@suse.de> (raw)
On x86 casting the unsigned int result of get_random_int() to long
may result in a negative value. On x86 the range of mmap_rnd()
therefore was -255 to 255. The 32bit mode on x86_64 used 0 to 255 as
intended.
The bug was introduced by commit 675a081 in January 2008.
Signed-off-by: Ludwig Nussel <ludwig.nussel@suse.de>
---
arch/x86/mm/mmap.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c
index 1dab519..f927429 100644
--- a/arch/x86/mm/mmap.c
+++ b/arch/x86/mm/mmap.c
@@ -87,9 +87,9 @@ static unsigned long mmap_rnd(void)
*/
if (current->flags & PF_RANDOMIZE) {
if (mmap_is_ia32())
- rnd = (long)get_random_int() % (1<<8);
+ rnd = get_random_int() % (1<<8);
else
- rnd = (long)(get_random_int() % (1<<28));
+ rnd = get_random_int() % (1<<28);
}
return rnd << PAGE_SHIFT;
}
--
1.7.3.4
next reply other threads:[~2011-02-28 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 14:53 Ludwig Nussel [this message]
2011-02-28 16:42 ` Randy Dunlap
2011-03-01 8:21 ` Ludwig Nussel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298904783-4291-1-git-send-email-ludwig.nussel@suse.de \
--to=ludwig.nussel@suse.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®