mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: linux-kernel@vger.kernel.org
Cc: "Peter Tyser" <ptyser@xes-inc.com>, "Alek Du" <alek.du@intel.com>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"David Brownell" <dbrownell@users.sourceforge.net>,
	"Eric Miao" <eric.y.miao@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
	"Joe Perches" <joe@perches.com>,
	"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
	"Grant Likely" <grant.likely@secretlab.ca>
Subject: [PATCH v5 3/4] gpio: pca953x: Implement get_direction() hook
Date: Tue,  1 Mar 2011 17:28:19 -0600	[thread overview]
Message-ID: <1299022100-14564-3-git-send-email-ptyser@xes-inc.com> (raw)
In-Reply-To: <1299022100-14564-1-git-send-email-ptyser@xes-inc.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1736 bytes --]

Adding the get_direction() function allows the accurate GPIO pin
direction data to be shown in sysfs.  Previously, the direction was
was always initialized to 'unknown'.

Cc: Alek Du <alek.du@intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: David Brownell <dbrownell@users.sourceforge.net>
Cc: Eric Miao <eric.y.miao@gmail.com>
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Joe Perches <joe@perches.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
---
Changes since v1:
- None

Changes since v2:
- Use GPIOF_DIR_* defines

Changes since v3:
- None

Change since V4:
- None

 drivers/gpio/pca953x.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
index b473429..b93611f 100644
--- a/drivers/gpio/pca953x.c
+++ b/drivers/gpio/pca953x.c
@@ -168,6 +168,15 @@ exit:
 	return ret;
 }
 
+static int pca953x_gpio_get_direction(struct gpio_chip *gc, unsigned off)
+{
+	struct pca953x_chip *chip;
+
+	chip = container_of(gc, struct pca953x_chip, gpio_chip);
+
+	return chip->reg_direction & (1u << off) ? GPIOF_DIR_IN : GPIOF_DIR_OUT;
+}
+
 static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off)
 {
 	struct pca953x_chip *chip;
@@ -221,6 +230,7 @@ static void pca953x_setup_gpio(struct pca953x_chip *chip, int gpios)
 
 	gc->direction_input  = pca953x_gpio_direction_input;
 	gc->direction_output = pca953x_gpio_direction_output;
+	gc->get_direction = pca953x_gpio_get_direction;
 	gc->get = pca953x_gpio_get_value;
 	gc->set = pca953x_gpio_set_value;
 	gc->can_sleep = 1;
-- 
1.7.0.4


  parent reply	other threads:[~2011-03-01 23:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 23:28 [PATCH v5 1/4] gpiolib: Add "unknown" direction support Peter Tyser
2011-03-01 23:28 ` [PATCH v5 2/4] gpiolib: Add ability to get GPIO direction Peter Tyser
2011-03-06  7:30   ` Grant Likely
2011-03-07  3:07     ` Peter Tyser
2011-03-07  7:08       ` Grant Likely
2011-03-08  0:38         ` Peter Tyser
2011-03-11 17:48           ` Peter Tyser
2011-03-12  9:18           ` Grant Likely
2011-04-20 22:17             ` Peter Tyser
2011-04-20 22:41               ` Mike Frysinger
2011-03-08 12:13         ` Alan Cox
2011-03-09 22:53           ` Peter Tyser
2011-03-12  9:19             ` Grant Likely
2011-03-01 23:28 ` Peter Tyser [this message]
2011-03-01 23:28 ` [PATCH v5 4/4] gpio: Add support for Intel ICHx/3100/Series[56] GPIO Peter Tyser
2011-04-20 16:35   ` [PATCH v6] " Peter Tyser
2011-05-24 14:18     ` Peter Tyser
2011-05-27  6:42     ` Grant Likely
2011-05-27  9:01       ` Jean Delvare
2011-05-27 14:26         ` Peter Tyser
2011-05-27 20:55           ` Grant Likely
2011-05-27 21:29             ` Peter Tyser
2011-05-27 23:54               ` Grant Likely
2011-05-30 17:27                 ` Peter Tyser
2011-06-03 16:43                   ` Grant Likely
2011-03-06  7:25 ` [PATCH v5 1/4] gpiolib: Add "unknown" direction support Grant Likely
2011-03-06 20:19   ` Ryan Mallon
2011-03-07  2:48     ` Peter Tyser
2011-03-07  6:50     ` Grant Likely
2011-03-07  2:43   ` Peter Tyser
2011-03-07  6:52     ` Grant Likely
2011-03-08  0:28       ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299022100-14564-3-git-send-email-ptyser@xes-inc.com \
    --to=ptyser@xes-inc.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=alek.du@intel.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eric.y.miao@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®