mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armijn Hemel <armijn@gpl-violations.org>
To: s.gottschall@newmedia-net.de
Cc: laforge@gpl-violations.org, linux-kernel@vger.kernel.org
Subject: changing EXPORT_SYMBOL_GPL to EXPORT_SYMBOL in DD-WRT
Date: Thu, 03 Mar 2011 15:55:59 +0100	[thread overview]
Message-ID: <1299164159.10725.19.camel@hibbert> (raw)

hello Sebastian,

I noticed that a few hours ago you changed a few lines in the kernel
source of DD-WRT, changing the export from a few symbols from 'GPL only'
to something a lot more permissive:

http://svn.dd-wrt.com:8000/changeset/16368

As you are probably aware the EXPORT_SYMBOL_GPL macro is there to
clearly signal that it was the author's intent to make these symbols
only available to GPL licensed kernel modules. What you have effectively
done is ignore the author's intent. It also might end up in DD-WRT
derivatives.

I am sure that this is not what you meant to do. The commit message
indicates that you are working around a certain problem you are facing
with DD-WRT. I am sure that the Linux kernel developers would love to
hear about that problem. For your convenience I have put them in CC.

warm regards,

armijn

-- 
 ---------------------------------------------------------------------------
        armijn@gpl-violations.org || http://www.gpl-violations.org/
 ---------------------------------------------------------------------------


             reply	other threads:[~2011-03-03 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03 14:55 Armijn Hemel [this message]
2011-03-03 15:23 ` Harald Welte
     [not found]   ` <4D6FCA08.1080705@dd-wrt.com>
2011-03-03 18:07     ` Christian Scheele

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299164159.10725.19.camel@hibbert \
    --to=armijn@gpl-violations.org \
    --cc=laforge@gpl-violations.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.gottschall@newmedia-net.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome