From: Mike Galbraith <efault@gmx.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@elte.hu>
Subject: [patchlet] sched: fix rt throttle runtime borrowing
Date: Mon, 07 Mar 2011 09:21:41 +0100 [thread overview]
Message-ID: <1299486101.14465.25.camel@marge.simson.net> (raw)
Greetings,
The RT throttle leaves a bit to be desired as a protection mechanism.
With default settings, the thing won't save your bacon if you start a
single hog as RT on SMP box, or if your normally sane app goes nuts.
With the below, my box will limp along so I can kill the RT hog. May
not be the best solution, but works for me.. modulo bustage I haven't
noticed yet of course.
sched: fix rt throttle runtime borrowing
If allowed to borrow up to rt_period, the throttle has no effect on an out
of control RT task, allowing it to consume 100% CPU indefinitely, blocking
system critical SCHED_NORMAL threads indefinitely.
Signed-off-by: Mike Galbraith <efault@gmx.de>
---
kernel/sched_rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/kernel/sched_rt.c
===================================================================
--- linux-2.6.orig/kernel/sched_rt.c
+++ linux-2.6/kernel/sched_rt.c
@@ -354,7 +354,7 @@ static int do_balance_runtime(struct rt_
weight = cpumask_weight(rd->span);
raw_spin_lock(&rt_b->rt_runtime_lock);
- rt_period = ktime_to_ns(rt_b->rt_period);
+ rt_period = ktime_to_ns(rt_b->rt_period) - 1;
for_each_cpu(i, rd->span) {
struct rt_rq *iter = sched_rt_period_rt_rq(rt_b, i);
s64 diff;
next reply other threads:[~2011-03-07 8:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 8:21 Mike Galbraith [this message]
2011-03-07 9:11 ` Yong Zhang
2011-03-07 9:33 ` Mike Galbraith
2011-03-07 14:27 ` Mike Galbraith
2011-03-08 8:23 ` Yong Zhang
2011-03-08 8:26 ` Mike Galbraith
2011-03-08 12:46 ` Peter Zijlstra
2011-03-08 13:27 ` Mike Galbraith
2011-03-08 13:46 ` Peter Zijlstra
2011-03-08 14:25 ` Mike Galbraith
2011-03-08 8:19 ` Yong Zhang
2011-03-08 8:28 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299486101.14465.25.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®