mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: Bhanu Gollapudi <bprakash@broadcom.com>
Cc: Mariusz Kozlowski <mk@lab.zgora.pl>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Subject: Re: [PATCH] [SCSI] bnx2fc: fix build error when !CONFIG_MODULES
Date: Mon, 07 Mar 2011 18:18:17 -0600	[thread overview]
Message-ID: <1299543497.15955.108.camel@mulgrave.site> (raw)
In-Reply-To: <1299542075.5232.5.camel@LTSJC-BPRAKASH.corp.ad.broadcom.com>

On Mon, 2011-03-07 at 15:54 -0800, Bhanu Gollapudi wrote:
> On Mon, 2011-03-07 at 12:16 -0800, Mariusz Kozlowski wrote: 
> > On Wed, Mar 02, 2011 at 11:10:03PM +0100, Mariusz Kozlowski wrote:
> > > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815: error: dereferencing pointer to incomplete type
> > > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1815: error: ‘MODULE_STATE_LIVE’ undeclared (first use in this function)
> > 
> > Hm. Still there in next-20110307. Is this patch wrong or..?
> > 
> 
> James,
> 
> Here is my ack for this patch.

OK, so the patch is actually wrong because adding #ifdefs on modules in
files really impedes readability.  The bug is using a direct deref on
module state instead of one of the APIs which work in the non-modular
case, namely try_module_get(). That means the other two need to come out
and be reworked (plus all the others in fcoe).

Reworked looks like it might be a bigger item than bnx2fc.  If any of
those tests is ever relevant, it means we have a race in the
fcoe_transport because it shouldn't be calling function pointers on a
dying module (unless it wants to trigger an oops).

So, why are you trying to do this in the first place?

James



  reply	other threads:[~2011-03-08  0:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-02  7:27 linux-next: Tree for March 2 Stephen Rothwell
2011-03-02 22:10 ` [PATCH] [SCSI] bnx2fc: fix build error when !CONFIG_MODULES Mariusz Kozlowski
2011-03-07 20:16   ` Mariusz Kozlowski
2011-03-07 23:54     ` Bhanu Gollapudi
2011-03-08  0:18       ` James Bottomley [this message]
2011-03-08  1:09         ` Robert Love
2011-03-08 19:36           ` Zou, Yi
2011-03-08 20:29             ` Bhanu Gollapudi
2011-03-10 15:32           ` James Bottomley
2011-03-12  2:03             ` Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299543497.15955.108.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=bprakash@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mk@lab.zgora.pl \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®