From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/2] perf: Fix the software events state check
Date: Wed, 09 Mar 2011 14:55:59 +0100 [thread overview]
Message-ID: <1299678959.2308.2989.camel@twins> (raw)
In-Reply-To: <20110309135252.GB1730@nowhere>
On Wed, 2011-03-09 at 14:52 +0100, Frederic Weisbecker wrote:
>
> It seems that ->stop() / ->start() are called from perf_adjust_period()
> to update the hardware with the new settings of period_left. The events
> are stopped to avoid any race with events triggering with a stale period_left
> in the hardware level when the software one has been updated, I guess.
>
> So it doesn't seem to fix any existing bug because for ->stop() and ->start()
> are only useful for hardware events right now. But we may call ->stop() and
> ->start() for further purpose later. In fact that paves the way for the event
> exclusion patchset I'm about to post.
>
> So it should be .39 material. But a confirmation from Peter would be nice.
Yeah, that sounds about right, I've already queued these patches
for .39.
next prev parent reply other threads:[~2011-03-09 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 20:27 Frederic Weisbecker
2011-03-07 20:27 ` [PATCH 2/2] perf: Handle stopped state with tracepoints Frederic Weisbecker
2011-03-16 13:58 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
2011-03-09 9:28 ` [PATCH 1/2] perf: Fix the software events state check Ingo Molnar
2011-03-09 13:52 ` Frederic Weisbecker
2011-03-09 13:55 ` Peter Zijlstra [this message]
2011-03-16 13:58 ` [tip:perf/urgent] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299678959.2308.2989.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®