mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-crypto <linux-crypto@vger.kernel.org>,
	James Bottomley <James.Bottomley@suse.de>,
	Christoph Hellwig <hch@lst.de>,
	Randy Dunlap <rdunlap@xenotime.net>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/2] Add struct crypto_alg->cra_check_optimized for crc32c_intel
Date: Thu, 10 Mar 2011 00:54:24 -0800	[thread overview]
Message-ID: <1299747264.5263.35.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20110310084346.GA10650@gondor.apana.org.au>

On Thu, 2011-03-10 at 16:43 +0800, Herbert Xu wrote:
> On Thu, Mar 10, 2011 at 12:21:10AM -0800, Nicholas A. Bellinger wrote:
> > 
> > Nicholas Bellinger (2):
> >   crypto: Add struct crypto_alg->cra_check_optimized
> >   crypto/crc32c: Add crc32c_cra_check_optimized for crc32c_intel
> 
> I think you misunderstood my suggestion.  The reason I asked
> for this to be done in the crypto API is because it is not specific
> to crc32c_intel.
> 
> So sending me a patch that modifies crc32c clearly misses the
> point :)
> 
> This should be done in the core API, i.e., api.c/algapi.c.
> 

OK, so you mean each struct crypto_alg should define something like a
'cra_optimized_name' for which request_module(alg->cra_optimized_name)
is called somewhere in libcrypto code..?

Would you mind being a bit more specific where this should be happening
in api.c/algapi.c..?

Thanks,

--nab


  reply	other threads:[~2011-03-10  9:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  8:21 Nicholas A. Bellinger
2011-03-10  8:21 ` [PATCH 1/2] crypto: Add struct crypto_alg->cra_check_optimized Nicholas A. Bellinger
2011-03-10  8:21 ` [PATCH 2/2] crypto/crc32c: Add crc32c_cra_check_optimized for crc32c_intel Nicholas A. Bellinger
2011-03-10  8:43 ` [PATCH 0/2] Add struct crypto_alg->cra_check_optimized " Herbert Xu
2011-03-10  8:54   ` Nicholas A. Bellinger [this message]
2011-03-10  9:09     ` Herbert Xu
2011-03-10  9:13       ` Nicholas A. Bellinger
2011-03-10 10:05         ` Nicholas A. Bellinger
2011-03-13  9:01           ` Herbert Xu
2011-03-14 12:14             ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299747264.5263.35.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=James.Bottomley@suse.de \
    --cc=hch@lst.de \
    --cc=herbert@gondor.hengli.com.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome