Re: [Xen-devel] [PATCH 13/14] xen: events: do not workaround too-small nr_irqs

[Ian Campbell <Ian.Campbell@eu.citrix.com>]

On Thu, 2011-03-10 at 05:40 +0000, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 09, 2011 at 05:41:25PM +0000, Ian Campbell wrote:
> > This workaround was somewhat useful prior to the introduction of the
> > core irq allocator and 026c9d2d0d75 "xen: events: allocate GSIs and
> > dynamic IRQs from separate IRQ ranges." but should be unnecessary now.
> 
> OK, so you tested this under QEMU with Xen + Dom0? A simple one CPU
> config was what we had trouble with.

Yes, I tested with:
qemu-system-x86_64 -m 256 -vnc 0.0.0.0:1 -k en-gb -serial stdio -boot nc \
	-usb -usbdevice tablet \
	-net nic,vlan=0,macaddr=00:16:3e:3f:73:b6,model=e1000 \
	-net tap,vlan=0,ifname=tapQEMU.0 \
	-hda /dev/VG/debian-HVM-1

Booting a recent Xen hypervisor + this kernel.

The comment should really have been updated to reflect the importance of
e7bcecb7b1d2 rather than 026c9d2d0d75. I'll update to:

        With the introduction of e7bcecb7b1d2 "genirq: Make nr_irqs
        runtime expandable" nr_irqs can grow as necessary to accommodate
        our allocation requests.

Ian.

> > 
> > If nr_irqs turns out to be too small under Xen then we should increase
> > nr_irqs rather than working around the core allocator in this way.
> > 
> > In my configuration NR_IRQS ends up being 2304 with nr_irq_gsi 272
> > which is sufficient.