mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	YiCheng Doe <yicheng.doe@hp.com>,
	Tom Mingarelli <thomas.mingarelli@hp.com>,
	Andy Cress <andy.cress@us.kontron.com>,
	Mika Lansirine <Mika.Lansirinne@stonesoft.com>,
	Brian De Wolf <bldewolf@csupomona.edu>,
	Jean Michel Audet <Jean-Michel.Audet@ca.Kontron.com>,
	Jozef Sudelsky <jozef.sudolsky@elbiahosting.sk>,
	Matthew Garrett <mjg@redhat.com>,
	Corey Minyard <cminyard@mvista.com>
Subject: [PATCH] ipmi: Fix IPMI errors due to timing problems
Date: Thu, 10 Mar 2011 14:00:21 -0600	[thread overview]
Message-ID: <1299787221-19542-1-git-send-email-minyard@acm.org> (raw)

From: Doe, YiCheng <yicheng.doe@hp.com>

This patch fixes an issue in OpenIPMI module where sometimes an ABORT command
is sent after sending an IPMI request to BMC causing the IPMI request to fail.

Signed-off-by: YiCheng Doe <yicheng.doe@hp.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Acked-by: Tom Mingarelli <thomas.mingarelli@hp.com>
Tested-by: Andy Cress <andy.cress@us.kontron.com>
Tested-by: Mika Lansirine <Mika.Lansirinne@stonesoft.com>
Tested-by: Brian De Wolf <bldewolf@csupomona.edu>
Cc: Jean Michel Audet <Jean-Michel.Audet@ca.Kontron.com>
Cc: Jozef Sudelsky <jozef.sudolsky@elbiahosting.sk>
Cc: Matthew Garrett <mjg@redhat.com>
---
 drivers/char/ipmi/ipmi_si_intf.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 7855f9f..62787e3 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -900,6 +900,14 @@ static void sender(void                *send_info,
 	printk("**Enqueue: %d.%9.9d\n", t.tv_sec, t.tv_usec);
 #endif
 
+	/*
+	 * last_timeout_jiffies is updated here to avoid
+	 * smi_timeout() handler passing very large time_diff
+	 * value to smi_event_handler() that causes
+	 * the send command to abort.
+	 */
+	smi_info->last_timeout_jiffies = jiffies;
+
 	mod_timer(&smi_info->si_timer, jiffies + SI_TIMEOUT_JIFFIES);
 
 	if (smi_info->thread)
-- 
1.7.1


             reply	other threads:[~2011-03-10 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 20:00 Corey Minyard [this message]
2011-03-10 20:21 ` Matthew Garrett
  -- strict thread matches above, loose matches on Subject: below --
2011-03-10 19:12 Corey Minyard
2011-03-10 19:17 ` Matthew Garrett
2011-03-10 19:26   ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299787221-19542-1-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=Jean-Michel.Audet@ca.Kontron.com \
    --cc=Mika.Lansirinne@stonesoft.com \
    --cc=andy.cress@us.kontron.com \
    --cc=bldewolf@csupomona.edu \
    --cc=cminyard@mvista.com \
    --cc=jozef.sudolsky@elbiahosting.sk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=thomas.mingarelli@hp.com \
    --cc=torvalds@linux-foundation.org \
    --cc=yicheng.doe@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®