From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BBC3F23A2 for ; Tue, 20 Jan 2026 12:07:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768910879; cv=none; b=WgEIx9cqoq3MKVxCME25A4ChsWCl8T0kWhQB63OcVcuqb6bjG5iykubG3L4KC7yuQkc4coclrtgUpV2Rb+rrsaOIYsHPaBbFYHoryspKzDC5WewF+Kv7zUYGmyIl7F/a4kpYHGFtO9lZcB5GquxdAZtbH02U0JjPa9lP8JTNc20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768910879; c=relaxed/simple; bh=b05Cognv3tUiO7IqOvpDVuBkV64SlDGjjUJiu+fSfxE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=he6fFH5ZCpxrh2up+LghUFK6OvFjJCvotQi3fuQXZZjdXyy8RdUjAJwachO7L7WcTvY9HD3C1OJAtkN9XWx4/TrRF9PKda2rhs0i0r5wyeKHhVylQ2YcR+//qNues2wxDNK2gf3aU6PgceeT2LPWUJVC12DPbZzO2qaEASpGbCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JpN3GeC9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HRQIwUH9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JpN3GeC9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HRQIwUH9" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60K6i5W8428970 for ; Tue, 20 Jan 2026 12:07:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vehV7GIcrMj79jW1UrHrfHlLOaXKMjfHHi3wPy7nX3A=; b=JpN3GeC9kNUxdFB5 wzVTVPnXktd+UuGyYaKJzFlsAnT3fQVHOkDmPLEsGbzdbd20HvaO8teNgipeeMSB ++iQThtWzw/yN7FWuMchQaaLNV5CmA/g3LrOT4ATrbhzfiRY9EaXmRzGMLmRmf3O SfuO+C+kt5w7VBSLuF9iH1zvmb5R/tXYJR5K3r0OsA4QX5iB7+u2ca2zuDdDN2Ix pu1a5DNIo5GRz7FX73OdF4oJT16jKLeWIBMDOhKFmChCCoGfUOv/6ifHVDei0pJB Z2g54C9yaKlsuG2N9/LSZGdAP7RKWH38AFHcYq0Ctff4xdxUX7DFIuIts6/gCz5+ 6wMRLA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bt4ps0y4u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Jan 2026 12:07:56 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c52d37d346dso2742965a12.3 for ; Tue, 20 Jan 2026 04:07:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768910876; x=1769515676; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vehV7GIcrMj79jW1UrHrfHlLOaXKMjfHHi3wPy7nX3A=; b=HRQIwUH9dM8rzj+x3+F+2r3pRk0dM12oqXJcBCh/rr+HM0y0Csw++Khb5+QqLnkxf4 DAOXvT0oxyPRlFt5u/jcVcP1lrx613ttA6EjQn9FqcpYcNuvDq/U9CWa6kTEsoGXoQVN QRi4kGS0Tg6v0QsvjemNRtDjDVU48DAfVZ+CPr9wRrGdSOK2YZoSPUiqLv8mCiA4gPpl nv4VU51BXJ3FI991QwcJwCi7bnMcbqlo2IXJQW2EwNa7oXSsEyRgmpkivlLH2/1wrL6j QT5YOdV5eZY6aZvPOMmLdq40KqiGQ5iKmEdGWC+yTRMFCZfOYFFye6jY98s8AYQto7py RJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768910876; x=1769515676; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vehV7GIcrMj79jW1UrHrfHlLOaXKMjfHHi3wPy7nX3A=; b=jti8MLZ1D9quu44Ozh8o4BVBLA4VExwjtgot3HlwrZ/OPAs403TSYDiJnjdYMDQVNr wObvNs8ILBBb69+3E3rvrjb03qPEaNvyB30Z3my5k6W3YCrUlO4SUOjrHDErbCx1AxKt 2H7XJU03gYEEY0+f1NJEfWlHaZ9EBurCnDaftrIJDNVNy6hLuv0JfGlnAGtoqzLO3poc 2ng8Wphezm5XVMUm7MX+5NVlk3BDhMnc8kIXTddiD7zlqasqLxRNPwO3xBPAN20NHlSr 1U/HoHriY/cG7lIvfT1PspraC12pkhiZFvCM3LnLAK7LnMCE+ZJIWSMyl1uclNKmFfWY HwoQ== X-Forwarded-Encrypted: i=1; AJvYcCV3H0DAfmNxNQodumrXF+yvxxGxeHsWNKCydD8yKgIhczFM7Uir18yPyYpVAFTYs0G7exVxueDKP2/RYx0=@vger.kernel.org X-Gm-Message-State: AOJu0YwFjWh+ljINvHqbHMR/lPKm/0TuWHqZKgUSgBiECtVWaV/ZL0Ur qoYG5zCg6X86loo1bQyAi0Pdz37eZLDu+iZmShh9nA/0tegx5uErI2GQ7lRK5bXL77ELQAi/uvz J0dutLPNfPBDcsRIURyTbMeEWgTlvGtkxiroejROyWM/43h3CacRTxFyVhvY6F1Um1Sw= X-Gm-Gg: AZuq6aKncLplTl5hhNliNV/NF+DslbmpzbTnOXWYDCPkYH/Qh1gak6/Lx97IyG2RLsr S1DAs7Ogz3K57sB7lZ0aF77qgPFc/8AH+6vvSrqXoMlEr8DX81DZ6lG0lZIHZa2sJhrAEldKSK6 xLqKE6AMOh0F+ZI1adpUccIB/M1lUi4qaEpW6VPCtTEuG/J9PpL6kfSVlHsEls+E27VuAkkGFXZ y2JedFY4snXB561gVoWJ6WzczGd61nVmhYa3wYpQhFNiQVLrVwUkifBG5PN6iX2hSJCChHgk0qs uaH60HAbZErHtjjjsWmxY4GrIUKAuXkZ8MIczoAnA85i2qv0PLBvxxkFRVGeNc0h9LoJ5WNhxBX bEp4xLLHL/VI2vdRgFEBTHtXJ35jYO6ojUz1v33G8uVhkTF17O0TUEyNGQpnoNpHao65NZaW1dX TEYRU0uJfM1riEJNUCDwh88+ghosTA X-Received: by 2002:a17:90a:ec83:b0:349:2136:83eb with SMTP id 98e67ed59e1d1-352c4079c64mr1440336a91.29.1768910874957; Tue, 20 Jan 2026 04:07:54 -0800 (PST) X-Received: by 2002:a17:90a:ec83:b0:349:2136:83eb with SMTP id 98e67ed59e1d1-352c4079c64mr1440300a91.29.1768910874302; Tue, 20 Jan 2026 04:07:54 -0800 (PST) Received: from [10.190.200.191] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c5edf354b16sm11820489a12.30.2026.01.20.04.07.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Jan 2026 04:07:53 -0800 (PST) Message-ID: <1299cddb-8205-47bc-89c4-98b4ddcd688c@oss.qualcomm.com> Date: Tue, 20 Jan 2026 17:37:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT 3/3] arm64: dts: qcom: glymur-crd: Enable USB support To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Wesley Cheng Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Wesley Cheng References: <20260113-dts-qcom-glymur-add-usb-support-v1-0-98d6d387df01@oss.qualcomm.com> <20260113-dts-qcom-glymur-add-usb-support-v1-3-98d6d387df01@oss.qualcomm.com> Content-Language: en-US From: Pankaj Patil In-Reply-To: <20260113-dts-qcom-glymur-add-usb-support-v1-3-98d6d387df01@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: s2uOgK5Ovr_fw9aMhKKB-urM8WrC6wHS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIwMDEwMCBTYWx0ZWRfX4HYgHz70XK7D /GsKpv8GyDuhh097H/5/YRjDi4eH1+q0Kf4bRBOdF1gRgt1tdFf5qFo99/VcgOUzggh35K2dqdm MokHsfUJbCIUhne0yBvo86RsmroUYAzBdUoD/8RgMk+vhzPWKm+RVK3UZ1c5rBlI62cZmyGXwy/ AkbWuHphU3N0Xva2BIe7rr4GcVxhQ7+1Y+1swU+t27duy2+Nu4WW0/pVmrD9Z3Fpnpwcu6sgRLE EtmaMQUqMAheYf+ueafGrpK9PEffAcOBbzLLUwVm6fiX3myZk3OkB+7bDfJcUkpkYyy/8kls39b OX+bwFThtUqZWd8Q8noW4MIVn1uR77QF8qA4uPWmVty7PMr8pXR3MzoNShimuRGXAuXGiaaKJwX ACGuW8XujbuAt1Ks7FKRDQI53watrveykVLeGNzCQiOtwapHS7CgT/zo7+/TKo5MG9n0srtdW2h x0HJgtziIGyZYNTv5rQ== X-Authority-Analysis: v=2.4 cv=PdfyRyhd c=1 sm=1 tr=0 ts=696f701c cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=eW232guSyCytQ_mfRHkA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: s2uOgK5Ovr_fw9aMhKKB-urM8WrC6wHS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-20_03,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 phishscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601200100 On 1/13/2026 6:03 PM, Abel Vesa wrote: > From: Wesley Cheng > > The Qualcomm Glymur Compute Reference Device comes with 3 Type-C ports, > one USB Type-A, and a fingerprint reader connected over USB. Each of these > 3 Type-C ports are connected to one of the USB combo PHYs and one of the > M31 eUSB2 PHYs. The Type-A is connected to the USB Multi-port controller > via one of the M31 eUSB2 PHYs and one combo PHY. The fingerprint reader > is connected to the USB_2 controller. All M31 eUSB2 PHYs have associated > eUSB2 to USB 2.0 repeaters, which are either part of SMB2360 PMICs or > dedicated NXP PTN3222. > > So enable all needed controllers, PHYs and repeaters, while describing > their supplies. Also describe the PMIC glink graph for Type-C connectors. > > Signed-off-by: Wesley Cheng > Co-developed-by: Abel Vesa > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/glymur-crd.dts | 283 ++++++++++++++++++++++++++++++++ > 1 file changed, 283 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts > index 7c168e813f1e..3188bfa27bea 100644 > --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts > +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts > @@ -56,6 +56,97 @@ key-volume-up { > }; > }; > > + pmic-glink { > + compatible = "qcom,glymur-pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + connector@0 { > + compatible = "usb-c-connector"; > + reg = <0>; > + > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pmic_glink_hs_in: endpoint { > + remote-endpoint = <&usb1_ss0_dwc3_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pmic_glink_ss_in: endpoint { > + remote-endpoint = <&usb1_ss0_qmpphy_out>; > + }; > + }; > + }; > + }; > + > + connector@1 { > + compatible = "usb-c-connector"; > + reg = <1>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pmic_glink_hs_in1: endpoint { > + remote-endpoint = <&usb1_ss1_dwc3_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pmic_glink_ss_in1: endpoint { > + remote-endpoint = <&usb1_ss1_qmpphy_out>; > + }; > + }; > + }; > + }; > + > + connector@2 { > + compatible = "usb-c-connector"; > + reg = <2>; > + power-role = "dual"; > + data-role = "dual"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + pmic_glink_hs_in2: endpoint { > + remote-endpoint = <&usb1_ss2_dwc3_hs>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + pmic_glink_ss_in2: endpoint { > + remote-endpoint = <&usb1_ss2_qmpphy_out>; > + }; > + }; > + }; > + }; > + }; > + > vreg_nvme: regulator-nvme { > compatible = "regulator-fixed"; > > @@ -331,6 +422,72 @@ trip1 { > }; > }; > > +&i2c5 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + ptn3222_0: redriver@43 { > + compatible = "nxp,ptn3222"; > + reg = <0x43>; > + > + reset-gpios = <&tlmm 8 GPIO_ACTIVE_LOW>; > + > + vdd3v3-supply = <&vreg_l8b_e0_1p50>; > + vdd1v8-supply = <&vreg_l15b_e0_1p8>; > + > + #phy-cells = <0>; > + }; > + > + ptn3222_1: redriver@4f { > + compatible = "nxp,ptn3222"; > + reg = <0x4f>; > + > + reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>; > + > + vdd3v3-supply = <&vreg_l8b_e0_1p50>; > + vdd1v8-supply = <&vreg_l15b_e0_1p8>; > + > + #phy-cells = <0>; > + }; > + > + ptn3222_2: redriver@47 { > + compatible = "nxp,ptn3222"; > + reg = <0x47>; > + > + reset-gpios = <&tlmm 9 GPIO_ACTIVE_LOW>; > + > + vdd3v3-supply = <&vreg_l8b_e0_1p50>; > + vdd1v8-supply = <&vreg_l15b_e0_1p8>; > + > + #phy-cells = <0>; > + }; > +}; > + > +&smb2370_j_e2_eusb2_repeater { > + vdd18-supply = <&vreg_l15b_e0_1p8>; > + vdd3-supply = <&vreg_l7b_e0_2p79>; > +}; > + > +&smb2370_k_e2_eusb2_repeater { > + vdd18-supply = <&vreg_l15b_e0_1p8>; > + vdd3-supply = <&vreg_l7b_e0_2p79>; > +}; > + > +&smb2370_l_e2_eusb2_repeater { > + vdd18-supply = <&vreg_l15b_e0_1p8>; > + vdd3-supply = <&vreg_l7b_e0_2p79>; > +}; > + > +&usb1_ss0_hsphy { > + vdd-supply = <&vreg_l3f_e0_0p72>; > + vdda12-supply = <&vreg_l4h_e0_1p2>; > + > + phys = <&smb2370_j_e2_eusb2_repeater>; > + > + status = "okay"; > +}; > + > &tlmm { > gpio-reserved-ranges = <4 4>, /* EC TZ Secure I3C */ > <10 2>, /* OOB UART */ > @@ -858,3 +1015,129 @@ &pcie6_port0 { > reset-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>; > wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>; > }; > + > +&usb1_ss0_qmpphy { > + vdda-phy-supply = <&vreg_l4h_e0_1p2>; > + vdda-pll-supply = <&vreg_l3f_e0_0p72>; > + refgen-supply = <&vreg_l2f_e0_0p82>; > + > + status = "okay"; > +}; > + > +&usb1_ss0_qmpphy_out { > + remote-endpoint = <&pmic_glink_ss_in>; > +}; > + > +&usb1_ss0_dwc3_hs { > + remote-endpoint = <&pmic_glink_hs_in>; > +}; > + > +&usb1_ss0 { > + status = "okay"; > +}; > + > +&usb1_ss1_qmpphy_out { > + remote-endpoint = <&pmic_glink_ss_in1>; > +}; > + > +&usb1_ss1_dwc3_hs { > + remote-endpoint = <&pmic_glink_hs_in1>; > +}; > + > +&usb1_ss1_hsphy { > + vdd-supply = <&vreg_l3f_e0_0p72>; > + vdda12-supply = <&vreg_l4h_e0_1p2>; > + Board clocks are missing from this and &usb1_ss0_hsphy node > + phys = <&smb2370_k_e2_eusb2_repeater>; > + > + status = "okay"; > +}; > + > +&usb1_ss1_qmpphy { > + vdda-phy-supply = <&vreg_l4h_e0_1p2>; > + vdda-pll-supply = <&vreg_l1h_e0_0p89>; > + refgen-supply = <&vreg_l2f_e0_0p82>; > + > + status = "okay"; > +}; > + > +&usb1_ss1 { > + status = "okay"; > +}; > + > +&usb1_ss2_qmpphy_out { > + remote-endpoint = <&pmic_glink_ss_in2>; > +}; > + > +&usb1_ss2_dwc3_hs { > + remote-endpoint = <&pmic_glink_hs_in2>; > +}; > + > +&usb1_ss2_hsphy { > + vdd-supply = <&vreg_l4c_e1_0p72>; > + vdda12-supply = <&vreg_l4f_e1_1p08>; > + > + phys = <&smb2370_l_e2_eusb2_repeater>; > + > + status = "okay"; > +}; > + > +&usb1_ss2_qmpphy { > + vdda-phy-supply = <&vreg_l4f_e1_1p08>; > + vdda-pll-supply = <&vreg_l4c_e1_0p72>; > + refgen-supply = <&vreg_l1c_e1_0p82>; > + > + status = "okay"; > +}; > + > +&usb1_ss2 { > + status = "okay"; > +}; > + > +&usb_2 { > + status = "okay"; > +}; > + > +&usb_2_hsphy { > + phys = <&ptn3222_2>; > + > + status = "okay"; > +}; > + > +&usb_mp_hsphy0 { > + vdd-supply = <&vreg_l2h_e0_0p72>; > + vdda12-supply = <&vreg_l4h_e0_1p2>; > + > + phys = <&ptn3222_0>; > + > + status = "okay"; > +}; > + > +&usb_mp_hsphy1 { > + vdd-supply = <&vreg_l2h_e0_0p72>; > + vdda12-supply = <&vreg_l4h_e0_1p2>; > + > + phys = <&ptn3222_1>; > + > + status = "okay"; > +}; > + > +&usb_mp_qmpphy0 { > + vdda-phy-supply = <&vreg_l4h_e0_1p2>; > + vdda-pll-supply = <&vreg_l2h_e0_0p72>; > + refgen-supply = <&vreg_l4f_e1_1p08>; > + > + status = "okay"; > +}; > + > +&usb_mp_qmpphy1 { > + vdda-phy-supply = <&vreg_l4h_e0_1p2>; > + vdda-pll-supply = <&vreg_l2h_e0_0p72>; > + refgen-supply = <&vreg_l4f_e1_1p08>; > + > + status = "okay"; > +}; > + > +&usb_mp { > + status = "okay"; > +}; >