From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbdATPna (ORCPT ); Fri, 20 Jan 2017 10:43:30 -0500 Received: from mail-sn1nam02on0065.outbound.protection.outlook.com ([104.47.36.65]:34720 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752029AbdATPn1 (ORCPT ); Fri, 20 Jan 2017 10:43:27 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Subject: Re: [PATCH 0/2] Introduce AMD Secure Processor device To: Greg KH References: <148484927002.30852.10568570584817827556.stgit@brijesh-build-machine> <20170119182101.GB30851@kroah.com> <0442f536-221d-fcef-3009-4bc07403ccd8@amd.com> <20170120084530.GA25333@kroah.com> CC: , , , , , , , , , , From: Brijesh Singh Message-ID: <129bc948-6836-bf0f-832e-525f0805c549@amd.com> Date: Fri, 20 Jan 2017 09:40:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170120084530.GA25333@kroah.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR12CA0070.namprd12.prod.outlook.com (10.175.83.160) To SN1PR12MB0671.namprd12.prod.outlook.com (10.163.208.29) X-MS-Office365-Filtering-Correlation-Id: 1f40b4c8-6ac2-4a19-5fc4-08d4414ab782 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN1PR12MB0671; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;3:QzCuc0mNUfE5W1ZvYY+inEYefseaoyzPQQJXNG7mwbjk9xd7ssVdbku1KmdnYMBcKulDF5nHweUK7DJMgLRgbkh+Ds58wCt92oj6J3mdL3Exq4BuPJn985VG1lW6MiEF+gT9acxY0IL6Bqh63GHXsFTiW0XJKzczaWu5th+NUhgWmc/V4opLjjagb1r5qtMDydm6bCn7HCZUUamTMbRjySBumHVHTaR8ht/9px0d2Q5txJhnLDfPOsNfgjKvS/K9HPAHQ5w/achdEgIrjF3bSA==;25:UDumwwNB/qLw9MqpAJBGdXr5g0F0LvBYXcjncFnpg1jorVJDHABcvAQ3VUPimV6c0UQ7sf/inXgteP9AyuQHJKX0CpRjSeuUSsQhlIqQfYpTjOiyJTU+iDXggbwkJluUz9Ab/zF4dCj6plqKGLWapqlijzLrjcdhcFrOxt5ZH4eqFzQkO6TZh5GooEFz07gQCAgeE/XqNUBGoUYXw6q1Z+AKtPnTJwJwoCUiyXcd2l6g00uNWRCyA4zfobx3d9sQG2TfRlY8L9ts3PVzXpJH9F8MvIJ5MG9XwzPkBj8HZVyNcin3LD9HWuJzv7FMwIUL0u0r/wIkylLbSEhNi6VZYZSEj1cGtC2RKfEjPZ+EOGgjwZL1i26VfjxQfo11Md+8nhcvdjVd78IO7a2fAx8BWsw0Jn6Od3bx3fXS4o9P6Zcy1cRZy9VkIV2Kj1sV2J1SsKQNE9hmwo8fRz7Y4yNgoQ== X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;31:iFZQyQMz0H7b90uZPSB2Sb8F9phPjdR46wYNjNw0gewu3kZLHD+pGO/dKZwoby0cVw+U2MhWZJ3ehaBd3h3aAFUBURF4ufTAJgYH6GYzLVo1MruaIbKXJoXa7SffwKRtIYvMue9Q7CGgYlNe+vcgaQ+T0pEN51t7nNaGQwS4dWeGeo5cBj9EfmByKzzzQBv9k83aOvWss8HJmIr5tqO+6aGgVer6nfEp2PVl/RR0yK13bUONvz1ZBDoF+JwjajVW;20:w7/x75thIZjZwOc7YXPsAwiBCh+ipszEn098y1oakqsLdTDBRg8W1FLYI7efynnLC/QQd+mSo9P/A8yX5r5DZb9WAvelyf4MwF8aB5s/X3MhuHZJz9ISAQduNBhzJ4tNqCZbGx2kCWlFmL7EXjwfnpKjBnPhYMirl02PixisD7mklQph3oywA1gzRzXVsQkeExJfoDh45zR3MYyuSed00TGJjsdhKOykF5J5pfJ2Q1hS1IFCATArPqtB5N2tmu2m+w8uFldW6Zke0TAtxM5uRJUeXIpdFYvu3ZFXbM3bIAFFY2oH/AGVyHynwyJg36ECgk76TeKsvfdHDBBhOlxpNH7BSvlI+pak65PRcYf4mQqHRqXe/qBnxMNNnD9zdu2++htYazLvieeQ+To5R8VvLhV4aV1mBJGVnehOsLLoDVa2u5QBnTElYt+zzEoxooN38zs5WvO5Lph3qfde+afRXvfAunOv7Oks5jwPP/T2rC1KOo6R5oZE4AkI8rHziQOA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(6072148);SRVR:SN1PR12MB0671;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0671; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;4:P+NKLEXobuckrWk4AFPsYrSuBbk6OwkPmm2WHNNACEBw6yJ4pYt035EJQlLOV5x0cTan2oVIpkqir3z80LkvzC2hn0Lucjp8VkIOD0BruRewJYaemioTQhvjBhVezYrp8MLYPQQ4QopfbVgJBC7ZOZBx75prs8PdJ3Ekgp7BQY7XN5IO6HwNrMRdScwFD9nJl22oEyBxROz6guJ4yq0jpMphVGMAJ4inH7WWODL7RzJcPMwIlWPTWbb4KxDYYywFvaJZVVa5eOSTRdw2Af7YI0IjzUVWGVC7g193SPeF4gxw5IM5w4pbPFpZnu5tG0KLIXXf6QY1TWNpjwwtjWPv4jSDNglpHdyH12cu71jPm3qUpssTm+ooIu40zxFqozzG5bd6/q3kJ6TODlzB3IcBSCsbQP7nSTCoCN2pQ2oj7MKh/6tl0su+T0RSXlWHxmsXd+kqk9Tc1Q0hiQUsiiJ3xukqr9qRWsCvqAB9UywAD5EigxQ2nW2kTrViK3Cc6vzYk4itrpXsXkKi0KJ3uy53rdRCKpAYMXhe7HogCAK8j4brKvlgGioTIwKibBtjFr0QxVOPikM1OyEnKYbbqKmjVqWfScPPRA3jAaCjd/6aJnoKDZXDG+rz5/fnVhDznARzmRXtIEX47g+6/fsSjJC5qQ== X-Forefront-PRVS: 01930B2BA8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39860400002)(39450400003)(39840400002)(39850400002)(39410400002)(209900001)(189002)(24454002)(199003)(377454003)(97736004)(86362001)(4001350100001)(106356001)(31696002)(3846002)(6116002)(101416001)(6486002)(90366009)(77096006)(39060400001)(50986999)(76176999)(54356999)(229853002)(189998001)(38730400001)(5660300001)(81156014)(54906002)(8676002)(105586002)(25786008)(36756003)(65956001)(65806001)(66066001)(305945005)(7736002)(4326007)(6666003)(23746002)(81166006)(2950100002)(6916009)(230700001)(15395725005)(64126003)(33646002)(53936002)(6306002)(47776003)(2906002)(92566002)(65826007)(42186005)(93886004)(31686004)(68736007)(110136003)(50466002)(83506001)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0671;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0671;23:jDgoc2mf4RmznxRqzYNtRhQ3lCcgYmIYvymeN?= =?Windows-1252?Q?c8D6TzEqvS/hLNrHkBnku9wY2KwdzDx6bSz2X5xuqizWGXqmor4WTQwq?= =?Windows-1252?Q?xLP4vMETwficoogxltJPguHZ6obKc9eOU10woxxwaxEJK0IlluXJRgWD?= =?Windows-1252?Q?vMnwUB11bIfeeCzXLmlncZ+yKP8Y5XhKEAeln6Xwm8EmRD5t5LFx/ysq?= =?Windows-1252?Q?wYmSTLycKkyoEXN/gWlxjlHjiw5CIUOXuJYENPwaTYHE1DiC9WRn3MZu?= =?Windows-1252?Q?Fz9cCq+DOP4S2VCqibmBMXFxTGqidrzh54WdTCXtYfoZQqswwEMGTygX?= =?Windows-1252?Q?pBwYPSYwzm2+MXM8DVMJK7MJJ3lgROlmcSmqRsdakoHnLv+jS6YOee5K?= =?Windows-1252?Q?8lwF2mw3CzyUshimiZCk3CPuGrg3shYp9he6MO15P6K5GPlNIRuLFsva?= =?Windows-1252?Q?5y1lJTJwblZBa2+W+XuVxF8/C+3Ln52dtWOIeHjCLraRQP/J7ZPWOa+O?= =?Windows-1252?Q?PvXCqPeI2+RRBZDhkMMHaZeaH+6WDVb2IcENRznkQHnpeXLgkdFLvdYN?= =?Windows-1252?Q?BaGE0+3EOVKB+JA5JHfX7cLDdcY9kRK8CWeoujhAqrzWxfjYsIUxdVaF?= =?Windows-1252?Q?e2tr7VVBFxc4XwANDOC8Vj5+mt6+t1sSVXS0497QvcLPrVPQMEZim7Qi?= =?Windows-1252?Q?Xa7IcpfPH91X1kexMUzJjpigGofMQaD9vmn39HprsiKMY9+1llQYwQCJ?= =?Windows-1252?Q?8iLDs53LLjc6TzI9pAhUyBvZqEAhbAXGhL7VFzGkeBj0bYgo49H4fdvq?= =?Windows-1252?Q?CxQEkYmjsKqQpQoiExYd5y0tFkpmjoqSNsyKhX32no8+Xqeb2oP1j4Or?= =?Windows-1252?Q?448YAv/2rORBtMHcQNSrsFgcsDVXat7WpCJE+yeUqO6zc5pjyEr1og6U?= =?Windows-1252?Q?G8KET3AgkVTqa0K1WF2YLcQ9MD7cxUfyrjIaxByAcA1fET5PyLX9zPm5?= =?Windows-1252?Q?BSKRK6wNuEJcOJ+QFzM8OdpKTozDrrTC8ErH9t0wm1GNATY0Hnx7wr3c?= =?Windows-1252?Q?0A6q+E0PbwjeXnQzU4TvU05VmS0jfyqWjgLmDv9cNiuTuV7T7RIDD0CK?= =?Windows-1252?Q?DmJI3RqnPIIqFRe410pg3jQia+QfrQKKqYP2RVaofoibho1dz+lGHdBL?= =?Windows-1252?Q?DlN1SOvmRQs3aBH3HE5OcvaLGlELU+RMdx2GBywJYa0NAJqb6qrtRFM5?= =?Windows-1252?Q?HR3Km9xk1mzBadyQ/rwz3iTUShOti1M6/UOYhNy53xFvNVzcC4/E7Otw?= =?Windows-1252?Q?yiuD8BtrfsVVK2LMh8VoQGgPHz52fllmMek+do8gHUUKLuJL8uMlZS5R?= =?Windows-1252?Q?L/4ug6V4/NutOmImn5EHp7HHem/CJNbNlQJUmR+leU/toSsPHqKXCUGT?= =?Windows-1252?Q?uE9AyTDaNxfjgU2km8yg0054M8uaRe3eJ7/yf96tW7LZk7OiP8ZzZV1y?= =?Windows-1252?Q?HWae91rWvc9RgC6NGSk/FEx9QayY/rhwssMezD+oO7pBreb9tpPflvED?= =?Windows-1252?Q?0jnM/K0nseOKdBC1PyzHW0Iyq3e+FW8yvk8Y7qCideLBNT2/CgtZHHVU?= =?Windows-1252?Q?xp/AowQrMIjl1QQUxj406BsOrN8wPzjhrfBn4I/NrdFqHyUvMpZ3TCKp?= =?Windows-1252?Q?BheSb149otTNBUoFakYSpisMmt8zW3H74ugaE+7vYNM+rHxNs0uhteRc?= =?Windows-1252?Q?/Dd2tEikBSHeH6mot2FHFiStPGb9tlcW4Od8g8=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;6:n98TsBYO6eeMqbNA+FLuuTRT4lK1XfMTGCpavoJuM48PAT5uYhziahc+Qu3g1t8CTWAM6irsxjIe3kM6KgFbXXadRqcjW28yTC1QNEwDDluBHRqza2gjQR5i61XSpg1Sf5NX8pf9gHD/1XuQfNsfhLJiappWGhOrigiP3ncjnrC47jB5PJhlMK9lYSZNPyyUV0LWT+wHu9EsNdejp/v7Wg9nDyJUfB21tzouvy7ls5zAE0AJc07d80U2f+pJXpYwBCRiqR4VrMdpb16VaPx2N0Mgtc3eHouf7mu0gw5IAxyLmbapYhkoZ3n0LeRte8pMZClkyshA+SCmNbYLtTRinjBwtT5Tnrj8/rrOJ+tLj/eQaLURo4S1K12NVDUqu94/Te09do+tV45PhiJzlfb+hPdjoOV2ATbLJZVcnOlMCpcLb0Q+T0IsX57I8+ukQW3gqTkcB2Up8d5AyTkzADv7Pg==;5:LZEWQBO67HqTiKVzqF4D5ZkQ1w4F7w4utQU+gmJTkb+VV6ZxwSSPb0JUDa/G7XQEL2JqZgf57Me6mf7tZNE68uCC23cWZdta9cuwy2y+NsltnVLUBr7G80PgTHgh9rn0sGGGZZfKFN/EHXRgP1Ya8tO3oK8LwK6fF79Y0gZuzdo=;24:6GWe97GYYAm9vF90KM1FOck7B/4jY2t34j44adz5ZKlCmza5kXisyHBAQ9A164OK+NeQl6Jo/assY8yXmtRRp44rZqafllIu1PVOzkjxUeU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0671;7:ughokALxcxzEk2S8DRVjPyUUxLj6CC0O5A217hjvEXomvnROHYzV7Brl1i3ARfYMRvV2JLKpZaZs5Rhp0IFQtB5Ykx9zum01nfTSd7BZb3JmnPxJNgk23qyb4tSTEMwO9LHx+awLuicXqIOXvpNdLn1NdASsToFoDVVqJOaSmZN8AjNWgLZseC07lQfPuKsoGw6DvdBuPp4lE7Ij3FjkZDbiQ87zkUXxUxb8pmBR49CKLC8EyxWWRxDup09Pl4AqMb1OzQuMIlFECSktehjBBftGb7U5Q/rbu996JS6xv/iT7Z3AXH812wpCTaHRY2nMp1qfpWabY6s/h/0hB9JFD/U/XtpqRjF+Ccd1foDcmuJe9dug7DGsiTKvKxuISKkzQe/6eNFswPQNuve6+t7E7BRuZzvIp/lqVAUs+iLqg6oXXqeU0cXhHTH8qtgPi9s0vgH9Qogb8OTm9EYQMClSKg==;20:2OHQ+J3L0mVopzBfIioxvKWetFSkjSnqD5n9gix+RMHs2aPu1yfIvVSzTTL6MJPeXKAY2U4mksP2zvY0RMwkJyoxyNNWG6LwQldxl04jH4/5RKwAdlxmyGU3ZRKepG4TLN1GcPmOV/e+h28S4nFdQNwGLMy1JaKHAf+jU0FYRpNqVEl0YVAX39Vh/duuxcvHiuBlEFrLTXUaxJCYC050IswU+EukuSRnPtis3soJnkjpiZTQu+y2II+trAcDImoL X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2017 15:40:52.1054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0671 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2017 02:45 AM, Greg KH wrote: > On Thu, Jan 19, 2017 at 02:03:12PM -0600, Brijesh Singh wrote: >> Hi Greg, >> >> On 01/19/2017 12:21 PM, Greg KH wrote: >>> On Thu, Jan 19, 2017 at 01:07:50PM -0500, Brijesh Singh wrote: >>>> The CCP device (drivers/crypto/ccp/ccp.ko) is part of AMD Secure Processor, >>>> which is not dedicated solely to crypto. The AMD Secure Processor includes >>>> CCP and PSP (Platform Secure Processor) devices. >>>> >>>> This patch series moves the CCP device driver to the misc directory and >>>> creates a framework that allows functional component of the AMD Secure >>>> Processor to be initialized and handled appropriately. >>> >>> Why the misc directory? I don't see the justification here... >>> >> >> Since this driver is not solely for crypto purposes and do not fit in any of >> the standard categories hence I thought of moving it into misc directory. I >> am open to other suggestions unless Herbert is ok with leaving it into >> crypto and allowing the addition of the Secure Processor support. >> >> The patch series allows the CCP driver to support other Secure Processor >> functions, e.g Secure Encrypted Virtualization (SEV) key management. In >> past, I tried to add SEV support into existing CCP driver [1] but we quickly >> learned that CCP driver should be moved outside the crypto directory >> otherwise will end up adding non crypto code into drivers/crypto directory. >> Once this cleanup is accepted then I can work to add SEV support inside the >> CCP driver. >> >> [1] http://marc.info/?l=linux-kernel&m=147204118426151&w=2 > > Ok, what type of interface will this driver have with userspace and/or > other parts of the kernel? Is there a misc char device burried in there > somewhere (I couldn't find it in the big diff sent out), or is this > driver just creating specific apis that other parts of the kernel will > call if available? > Eventually, the driver will export functions which will be used by KVM to encrypt the guest memory and more. Additionally, If SEV device is detected then driver will create a misc char device which can be used by userspace to import/export certificates etc. I do realize that we need to get some more context on why this refactoring is needed and how it will benefit the SEV device integration. I will drop this patch for now, will include it as part of next SEV RFC patch series (which provides the complete context with examples). thanks, ~ Brijesh > I think we need to see more code here, broken up into sane and > reviewable pieces, before we could either say "No don't do that!" or > "sure, let me go merge these!" :) > > thanks, > > greg k-h >