From: "Arnd Bergmann" <arnd@arndb.de>
To: "Charlie Jenkins" <charlie@rivosinc.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Conor Dooley" <conor@kernel.org>,
"Samuel Holland" <samuel.holland@sifive.com>,
"David Laight" <David.Laight@aculab.com>,
"Xiao W Wang" <xiao.w.wang@intel.com>,
"Evan Green" <evan@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>
Cc: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Albert Ou" <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v12 1/5] asm-generic: Improve csum_fold
Date: Wed, 13 Dec 2023 08:52:01 +0100 [thread overview]
Message-ID: <129fa764-dc7a-4979-95e8-39a15c487095@app.fastmail.com> (raw)
In-Reply-To: <20231212-optimize_checksum-v12-1-419a4ba6d666@rivosinc.com>
On Wed, Dec 13, 2023, at 02:18, Charlie Jenkins wrote:
> This csum_fold implementation introduced into arch/arc by Vineet Gupta
> is better than the default implementation on at least arc, x86, and
> riscv. Using GCC trunk and compiling non-inlined version, this
> implementation has 41.6667%, 25% fewer instructions on riscv64, x86-64
> respectively with -O3 optimization. Most implmentations override this
> default in asm, but this should be more performant than all of those
> other implementations except for arm which has barrel shifting and
> sparc32 which has a carry flag.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2023-12-13 7:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 1:18 [PATCH v12 0/5] riscv: Add fine-tuned checksum functions Charlie Jenkins
2023-12-13 1:18 ` [PATCH v12 1/5] asm-generic: Improve csum_fold Charlie Jenkins
2023-12-13 7:52 ` Arnd Bergmann [this message]
2023-12-13 1:18 ` [PATCH v12 2/5] riscv: Add static key for misaligned accesses Charlie Jenkins
2023-12-15 17:27 ` Evan Green
2023-12-13 1:18 ` [PATCH v12 3/5] riscv: Add checksum header Charlie Jenkins
2023-12-13 1:18 ` [PATCH v12 4/5] riscv: Add checksum library Charlie Jenkins
2023-12-13 2:10 ` Charlie Jenkins
2023-12-20 10:28 ` Wang, Xiao W
2023-12-13 1:18 ` [PATCH v12 5/5] kunit: Add tests for csum_ipv6_magic and ip_fast_csum Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129fa764-dc7a-4979-95e8-39a15c487095@app.fastmail.com \
--to=arnd@arndb.de \
--cc=David.Laight@aculab.com \
--cc=aou@eecs.berkeley.edu \
--cc=charlie@rivosinc.com \
--cc=conor@kernel.org \
--cc=evan@rivosinc.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®