From: Paolo Bonzini <pbonzini@redhat.com>
To: Ben Gardon <bgardon@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Peter Shier <pshier@google.com>,
"Maciej S . Szmigiero" <maciej.szmigiero@oracle.com>,
Leo Hou <leohou1402@gmail.com>
Subject: Re: [PATCH v3 2/2] KVM: x86/mmu: Clarify TDP MMU page list invariants
Date: Thu, 7 Jan 2021 18:32:53 +0100 [thread overview]
Message-ID: <12a3a6fd-557f-ae6f-4687-c4c4b2a79587@redhat.com> (raw)
In-Reply-To: <20210107001935.3732070-2-bgardon@google.com>
On 07/01/21 01:19, Ben Gardon wrote:
>
> - /* List of struct tdp_mmu_pages being used as roots */
> + /*
> + * List of struct tdp_mmu_pages being used as roots.
^^^
s/tdp/kvm/
Queued with this change, thanks.
Paolo
> + * All struct kvm_mmu_pages in the list should have
> + * tdp_mmu_page set.
> + * All struct kvm_mmu_pages in the list should have a positive
> + * root_count except when a thread holds the MMU lock and is removing
> + * an entry from the list.
> + */
> struct list_head tdp_mmu_roots;
> - /* List of struct tdp_mmu_pages not being used as roots */
> +
> + /*
> + * List of struct tdp_mmu_pages not being used as roots.
> + * All struct kvm_mmu_pages in the list should have
> + * tdp_mmu_page set and a root_count of 0.
> + */
next prev parent reply other threads:[~2021-01-07 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 0:19 [PATCH v3 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield Ben Gardon
2021-01-07 0:19 ` [PATCH v3 2/2] KVM: x86/mmu: Clarify TDP MMU page list invariants Ben Gardon
2021-01-07 17:32 ` Paolo Bonzini [this message]
2021-01-07 15:36 ` [PATCH v3 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield Maciej S. Szmigiero
2021-01-07 17:40 ` Sean Christopherson
2021-01-07 17:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12a3a6fd-557f-ae6f-4687-c4c4b2a79587@redhat.com \
--to=pbonzini@redhat.com \
--cc=bgardon@google.com \
--cc=kvm@vger.kernel.org \
--cc=leohou1402@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.szmigiero@oracle.com \
--cc=pshier@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®