From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-can@vger.kernel.org,
Christophe Lizzi <clizzi@redhat.com>,
imx@lists.linux.dev, Enric Balletbo <eballetb@redhat.com>,
Conor Dooley <conor+dt@kernel.org>, NXP S32 Linux <s32@nxp.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, Alberto Ruiz <aruizrui@redhat.com>
Subject: Re: [PATCH v4 1/3 RESEND] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support
Date: Mon, 13 Jan 2025 15:53:40 +0200 [thread overview]
Message-ID: <12a50b88-58ea-4df4-9770-68b1ab720d94@oss.nxp.com> (raw)
In-Reply-To: <173677598052.1702137.6360834668377737017.robh@kernel.org>
On 1/13/2025 3:46 PM, Rob Herring (Arm) wrote:
>
> On Mon, 13 Jan 2025 14:07:02 +0200, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> Add S32G2/S32G3 SoCs compatible strings.
>>
>> A particularity for these SoCs is the presence of separate interrupts for
>> state change, bus errors, MBs 0-7 and MBs 8-127 respectively.
>>
>> Increase maxItems of 'interrupts' to 4 for S32G based SoCs and keep the
>> same restriction for other SoCs.
>>
>> Also, as part of this commit, move the 'allOf' after the required
>> properties to make the documentation easier to read.
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>> .../bindings/net/can/fsl,flexcan.yaml | 44 +++++++++++++++++--
>> 1 file changed, 40 insertions(+), 4 deletions(-)
>>
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
>
> Missing tags:
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
>
>
Hello Rob,
I just wanted to add the RESEND word to these patch series because no
update was made with respect to its acceptance. Following [1] kernel
documentation for submitting patches I was not sure if by adding the
received 'Acked-by' to a commit it will still be correct to add the
RESEND word or I should send a new patch version on this series.
On short, my lack of addition for the 'Acked-by' was not on purpose.
[1] https://docs.kernel.org/process/submitting-patches.html
Best Regards,
Ciprian
next prev parent reply other threads:[~2025-01-13 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 12:07 [PATCH v4 0/3 RESEND] add FlexCAN support for S32G2/S32G3 SoCs Ciprian Costea
2025-01-13 12:07 ` [PATCH v4 1/3 RESEND] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support Ciprian Costea
2025-01-13 13:46 ` Rob Herring (Arm)
2025-01-13 13:53 ` Ciprian Marian Costea [this message]
2025-01-13 12:07 ` [PATCH v4 2/3 RESEND] can: flexcan: Add quirk to handle separate interrupt lines for mailboxes Ciprian Costea
2025-02-19 10:08 ` Marc Kleine-Budde
2025-01-13 12:07 ` [PATCH v4 3/3 RESEND] can: flexcan: add NXP S32G2/S32G3 SoC support Ciprian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12a50b88-58ea-4df4-9770-68b1ab720d94@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=aruizrui@redhat.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®