From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C4FC77B75 for ; Fri, 12 May 2023 10:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240562AbjELK2B (ORCPT ); Fri, 12 May 2023 06:28:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240584AbjELK1m (ORCPT ); Fri, 12 May 2023 06:27:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E325F1491C for ; Fri, 12 May 2023 03:26:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2418561554 for ; Fri, 12 May 2023 10:26:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86F9CC433D2; Fri, 12 May 2023 10:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683887183; bh=9BDmfoZuBPkbK1ZCLt7rh0uIS2qGSlS805RbZ3+nNas=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SHSt9d04W7mzK7GDELDQmwV2Qq4lp4vZlys2gQQ4hj3Zd8ANgnfXxWXicgHadPJvz l/YfYeioKj8/6euHdWmprwDRDVs7hPxBocqGj8JSyZ/P3jG36Fsly3adLB1JcvkBdA rIsFl37pduSjrYK8QM2TF9Wj2jpvtGoNXN05vcubd4RuVig3Nh8msV+rpCsbW1J0XE iHrvGfSNnSNnCjl57GHsYzVoSt9d5NfxMVGBUsmanhXCvD5rA47DnDMfcwVjotRDu/ WBaMilAfu4Vs5o/nbQ9ra1KwdJoMcDhktvOZBRAIF+XLDa36DhnV2yuDBLfsLeMNHa LVE9L/RdX03Fg== Message-ID: <12a57688-6e9a-a21d-41cb-978a274c8b2b@kernel.org> Date: Fri, 12 May 2023 12:26:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] w1: Replace usage of found with dedicated list iterator variable To: Jakob Koschel , Krzysztof Kozlowski Cc: Evgeniy Polyakov , linux-kernel@vger.kernel.org References: <20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2023 12:19, Jakob Koschel wrote: > How strange, I just checked and my checkpatch doesn't complain. > > I also redownloaded and double checked > (b4 am 20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com). > > What's the exact issue you are seeing? ✓ [PATCH v2] w1: Replace usage of found with dedicated list iterator variable + Link: https://lore.kernel.org/r/20230509-w1-replace-usage-of-found-with-tmp-list-iterator-variable-v2-1-259bf1ba44ed@gmail.com + Signed-off-by: Krzysztof Kozlowski --- ✗ No key: ed25519/jkl820.git@gmail.com ✓ Signed: DKIM/gmail.com --- Total patches: 1 --- Base: using specified base-commit eeac8ede17557680855031c6f305ece2378af326 Applying: w1: Replace usage of found with dedicated list iterator variable [Checking commit] 12b61e664c29 w1: Replace usage of found with dedicated list iterator variable [Checkpatch] CHECK: Alignment should match open parenthesis #70: FILE: drivers/w1/w1.c:849: + if (iter->reg_num.family == id->family && + iter->reg_num.id == id->id && Best regards, Krzysztof