From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Denzeel Oliva <wachiturroxd150@gmail.com>,
andi.shyti@kernel.org, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/3] spi: s3c64xx: prioritize fifo-depth from DT over port_config
Date: Fri, 14 Feb 2025 07:10:23 +0000 [thread overview]
Message-ID: <12a67e21-220c-40d6-a6e0-64ba23cf6ecf@linaro.org> (raw)
In-Reply-To: <20250214043343.263-3-wachiturroxd150@gmail.com>
On 2/14/25 4:33 AM, Denzeel Oliva wrote:
> Rearrange s3c64xx_spi_probe() to ensure that the 'fifo-depth' property
> from the device tree (DT) is always prioritized over the fallback
> values in port_config.
>
> Previously, if port_config had a fifo_depth value, it would override
> the DT property. This prevented DT from correctly setting the depth
> per node.
sigh. You had a fifo_depth of 0 in the driver at v1, this proves you
didn't test your patches, otherwise you would get a divide by zero.
You can't do that, you risk to get your contributions ignored:
https://lore.kernel.org/linux-samsung-soc/fbd06330-ccf3-485b-800f-83f624a7c90e@kernel.org/
Please provide prove of testing in v4.
Anyway, you shouldn't prioritize dt over compatible driver data, see my
replies in your v2.
next prev parent reply other threads:[~2025-02-14 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 4:33 [PATCH v3 0/3] spi: s3c64xx: add support exynos990-spi to new port config data Denzeel Oliva
2025-02-14 4:33 ` [PATCH v3 1/3] spi: dt-bindings: samsung: add samsung,exynos990-spi compatible Denzeel Oliva
2025-02-14 8:16 ` Krzysztof Kozlowski
2025-02-14 15:25 ` Sam Protsenko
2025-02-14 4:33 ` [PATCH v3 2/3] spi: s3c64xx: prioritize fifo-depth from DT over port_config Denzeel Oliva
2025-02-14 7:10 ` Tudor Ambarus [this message]
2025-02-14 4:33 ` [PATCH v3 3/3] spi: s3c64xx: add support exynos990-spi to new port config data Denzeel Oliva
2025-02-14 5:31 ` [PATCH v3 0/3] " Denzeel Oliva
2025-02-14 6:53 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12a67e21-220c-40d6-a6e0-64ba23cf6ecf@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®