From: Eric Auger <eric.auger@redhat.com>
To: Rafael Mendonca <rafaelmendsr@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Sinan Kaya <okaya@codeaurora.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: platform: Do not pass return buffer to ACPI _RST method
Date: Tue, 18 Oct 2022 18:45:58 +0200 [thread overview]
Message-ID: <12a6fae1-c7c5-c531-fce7-1a57cf6122fa@redhat.com> (raw)
In-Reply-To: <20221018152825.891032-1-rafaelmendsr@gmail.com>
Hi Rafael,
On 10/18/22 17:28, Rafael Mendonca wrote:
> The ACPI _RST method has no return value, there's no need to pass a return
> buffer to acpi_evaluate_object().
>
> Fixes: d30daa33ec1d ("vfio: platform: call _RST method when using ACPI")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> drivers/vfio/platform/vfio_platform_common.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index 55dc4f43c31e..1a0a238ffa35 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -72,12 +72,11 @@ static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev,
> const char **extra_dbg)
> {
> #ifdef CONFIG_ACPI
> - struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
> struct device *dev = vdev->device;
> acpi_handle handle = ACPI_HANDLE(dev);
> acpi_status acpi_ret;
>
> - acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, &buffer);
> + acpi_ret = acpi_evaluate_object(handle, "_RST", NULL, NULL);
> if (ACPI_FAILURE(acpi_ret)) {
> if (extra_dbg)
> *extra_dbg = acpi_format_exception(acpi_ret);
next prev parent reply other threads:[~2022-10-18 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 15:28 Rafael Mendonca
2022-10-18 16:45 ` Eric Auger [this message]
2022-11-10 20:16 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12a6fae1-c7c5-c531-fce7-1a57cf6122fa@redhat.com \
--to=eric.auger@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rafaelmendsr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®