From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4DE38B14D for ; Fri, 19 Jun 2026 12:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781873987; cv=none; b=IVejlGVEOLDQP/hVwlgQ68NyOJUAHNVJogQ+I7VQ7sN/us2fCOIiWGtU33Q7fWB+/x3zS9IG9EtINr8r4rLx7+ssH+QyESyRwWp8YYeU1Ytg0awWzNuURIJXQcGO0dHNuybYZ7ZaDjbV122hxu6C0u9ugcdJ9hCfdx0yUX2oTUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781873987; c=relaxed/simple; bh=B5pCpCW3fPa2uQlAQe2jred8xTwAmDOhSnaUI3XNfYM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RWFTeK14Yiy5xV8Nn9gdDD9FPquZPSdiPKZG8AVFzijohXL1RHcYE0wACHrQHuQe2yZdqYgt/aIMyFjDEZoyLT3vFOuqTX0gxPQVtlHo1ehBIegkCdBX3eWGaa0tognn0MGMryBYbyGXBlujcVMVcIQEsu4CSo3BfE0QR9rKYAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SJTOifDt; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SJTOifDt" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-396770b47eeso1631691fa.0 for ; Fri, 19 Jun 2026 05:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781873984; x=1782478784; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=sNXNfs7OoHqiz3UZ4G1yzyr8/Xuq38knH16nIszO0oc=; b=SJTOifDtEPMABEmTi/2y24pCu17o24gHAvA8A1e+kpCbDzm+0nNIRns+gxXk/W/LMI 1qaI72vE/xCi7foFsal8R0i7AQBb4hp0xjW/q8dInmDCsn5Bgui2Q0JBftQChds8AcXK Os3VZrPPtHE1n9jLljiG7Gm7P9Npy0eVDNB0Kief3zKOIP/0lPy0ZX2F2HQbXH0A6LI/ 5oqzEdNsCDDgi8Xbl/a811WZDj0rUer1ilgSF2czVHMnNXC/KbeMIynQUYLRuuw7ULBR kboG/O+Jk4FfEDIGljQzYg3TNXDTkHN1uqo1fxq8IseOMm8h9ja7XUlnB0XGEOTMdktm 3LNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781873984; x=1782478784; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sNXNfs7OoHqiz3UZ4G1yzyr8/Xuq38knH16nIszO0oc=; b=RHRB7nh/baABRil2tO10oZwZigXW0aYzrrT8K6QVHOOyfn93ksLs0tACPZtwVtsgJ/ /3Lx4OL6wSZ6ht+31RsllSqnHkraHNoYZtKJpz4ree/zfo77Ye4nkazgXjqfWFStRzlY 9UTKL9xdNMzbfcl4+LCZZvXjf8yfGMLRKnqOUrKelnJn7Xbsh46uYkK3L6l1KFEH7N/M elKF3e7vpFSEwD+qamQ5gjjzC9eGkWlgKKlDW26raYS3Bgp4Eh2BueBtCIYwvH6sjREl GbcsarkWRyW7o3gPsx/I+/pOg0CZHI0B3U2s+3Byv5oRlt00H9buj5V4cX0thNZaY831 zh+g== X-Forwarded-Encrypted: i=1; AFNElJ9PEgv8YzsOhkwDJNRlWl6gk1mN3/m/sXjWIMxki0lUt3/9c/ehkTSCHywPvDU4euStMnaUfgAbpha0opM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4/W9iIHkMfncZzjLmxtSnrjnxNn+BOq/YfSpgJzoCHc/5D47p +TmHG1ZuEQcemXQU8wPqkTWhwIRv8oVTnKAa2+MdJqoxdDyJxRITWcHXGeHPOTQ4SWA= X-Gm-Gg: AfdE7clBIT3UeqRZiLyK5rt4XJOvQoWcMngZIUcGRYDk5pfAekq4BNUVY/p4igFAftC tq4NRU+k9bX4zqu8VV7TG8xWfcbMJPkuTVoa0fx8kBpZ7CYppzHZfYv/6Lq4DmP3PAlpvZOt+sd pXCLSHSwNV+1pJz2VEXLPxpfXeIquzLRQJtsfX9BD9JX+zUYi04iGqSqBSxdaFQ2LuOcrVZZfBs LkPWPcqvd9qreCGxAh1R5kPw8W5gkfULB6i78GLEVb8N3gCXsc0ZX6xRSVxLl9GR9Ytd4hiicvh RyLFRtJjhgDkR2ULEiVFz6WcILuqM9HsWT9yMuG2WvS8F9pQYPtqeDeWIJrRfa3m06qQps0o6BH 6zwtNjXh67DbtjAFHNwOPPo534bh0N3/9mlOU1wb4/M28hpnV6L2NkOn7/MYBpJZXoP9ZTfQhqh LWQMr/EnjMOkdBXQlAx462917zygY3WPJa3T9imqqGQu5i3aWNLUv4nAQAXU17+i91O9l1MJe1z N1I+g== X-Received: by 2002:a05:651c:19a7:b0:393:9d8c:73d2 with SMTP id 38308e7fff4ca-39996b0af9emr606311fa.7.1781873984104; Fri, 19 Jun 2026 05:59:44 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3998bfeb6edsm4502291fa.19.2026.06.19.05.59.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 05:59:36 -0700 (PDT) Message-ID: <12a89ab8-dc43-4b55-9c95-36d44c75dcab@linaro.org> Date: Fri, 19 Jun 2026 15:59:35 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc8280xp: Add camera MCLK pinctrl To: Konrad Dybcio , Pengyu Luo Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260607160435.36546-1-mitltlatltl@gmail.com> <280402c0-57bd-46a3-b95c-f9ae02122a09@oss.qualcomm.com> <423b4e86-3837-4d69-8f56-d8259be53ff5@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <423b4e86-3837-4d69-8f56-d8259be53ff5@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/19/26 15:35, Konrad Dybcio wrote: > On 6/11/26 7:29 AM, Pengyu Luo wrote: >> On Tue, Jun 9, 2026 at 8:17 PM Konrad Dybcio >> wrote: >>> >>> On 6/7/26 6:04 PM, Pengyu Luo wrote: >>>> Define pinctrl definitions to enable camera master clocks on sc8280xp. >>>> >>>> Suggested-by: Vladimir Zapolskiy >>>> Signed-off-by: Pengyu Luo >>>> --- >>>> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 56 ++++++++++++++++++++++++++ >>>> 1 file changed, 56 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>> index a2bd6b10e475..0dbcd3069a3b 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi >>>> @@ -5484,6 +5484,62 @@ tlmm: pinctrl@f100000 { >>>> gpio-ranges = <&tlmm 0 0 230>; >>>> wakeup-parent = <&pdc>; >>>> >>>> + cam_mclk0_default: cam-mclk0-default-state { >>>> + pins = "gpio119"; >>>> + function = "cam_mclk"; >>>> + drive-strength = <6>; >>> >>> Other platforms set this to 2 by default. >>> >>> What's the value set on Windows when the camera is in use? >>> >> >> It is 6mA. >> >> Let us get ctl_reg first on Windows >> >> lkd> !dd f111000 L8 >> # f111000 00000284 00000002 000000e2 00000000 >> # f111010 00000001 00000801 00000000 00000000 >> >> ctl_reg => 0x284 >> >> in msm_gpio_dbg_show_one() >> ... >> drive = (ctl_reg >> g->drv_bit) & 7; // (0x284 >> 6) & 7 == 2 >> ... >> seq_printf(s, " %dmA", msm_regval_to_drive(drive)); // (drive + 1) * 2 == 6; >> ... >> >> x13s should be the same as gaokun3 in this part. > > I confirmed as much and I'm willing to believe this is a default for > all 8280 devices > > Reviewed-by: Konrad Dybcio > > for the second patch, please mention in the commit message that the value > will now match windows and please add a fixes tag > I believe the second change cannot be tagged as Fixes in sense that it strictly depends on a not going to be backported non-fix commit, and thus backporting of just 2/2 change as is will break the matter. Reordering of the commits placing the fix commit as the first one should be fine though. -- Best wishes, Vladimir