From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CAFCA9EBB for ; Thu, 24 Oct 2019 20:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FAAA2070B for ; Thu, 24 Oct 2019 20:36:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="cqY4m0Xy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728297AbfJXUgb (ORCPT ); Thu, 24 Oct 2019 16:36:31 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46549 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727677AbfJXUgb (ORCPT ); Thu, 24 Oct 2019 16:36:31 -0400 Received: by mail-wr1-f65.google.com with SMTP id n15so16723110wrw.13 for ; Thu, 24 Oct 2019 13:36:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=TcVdzhKCHKceqty/bwdBAIuB0q/LLF2xHZuEhIcLaNw=; b=cqY4m0XypXCSBqpzHHtWhgUFCHbmT57VQy8oBvnLAISynQINKKpzPP6+odj98MFuLE HluqoobpQbDLlzYbGlTU5gANVlaIukNdocp4R/2PpCbiGX6WIq5iDHqaFG2OEBKfgthz kyxybD6XLbFeFBfs1XEXDILzcwfH98xvfcKg0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=TcVdzhKCHKceqty/bwdBAIuB0q/LLF2xHZuEhIcLaNw=; b=AznGAt221k9k2G7cAEQXe+6JZcvLPd2J6AI6b62a30LxTbyYqVYRMx9Nvl4VpRDYV7 XkK0Unzcz0Zgu3w9BhVmXcayWrH+dvcmZri6Ao+k8HjyNc5VwBjGvb8UXg/pzfymJlmL Qc3oAkOxpc3IulKrReQf9q2oTVPtB4VMtxKOgAz4nodJG1PCCGhHVcd0kSXsQknzfs5N 5fYtmWbgQx4Y5U/Bfl1Gg6p9R3ZXtdmC+RqhYTKgUtHE0Ql5/kgbfnDwKLl17vk5pZRd 2CrEBjBt8L9kwwQSLIkF3nbzrYiKljzTUPAS89QtPd++OdB9htoXZMOitxuS7hqaQsOg aovA== X-Gm-Message-State: APjAAAVZZjouLDaAkGb5kWXXwa9MtS9Exu0XdjOvI779LvLoipgRnvBS uS5EB7cLMniLSWDeLL3muh/1i9ttKXgY8ZNtUZfiwYcPydgv5JUWqj9QFOp8YQWtkn9EWBoriO7 +I5K9z1fIjoMWmorFvFbIo5KNc42vy3iuyrWyeyhm2Gkf0xte4lC09a5STwp4oqObBKkkRUOCsu 4sid6oj7VHNT4= X-Google-Smtp-Source: APXvYqziKV2Dmlxn7bGB5F4iUFgJyQstWtSJc7wJ+q0Mtatc28JLRUxC2wgpiMudMnrZyLRPQIFYJQ== X-Received: by 2002:adf:bad3:: with SMTP id w19mr6002008wrg.17.1571949388807; Thu, 24 Oct 2019 13:36:28 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id b196sm5240713wmd.24.2019.10.24.13.36.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Oct 2019 13:36:27 -0700 (PDT) Subject: Re: [PATCH v4 0/2] gpio: brcm: XGS iProc GPIO driver To: Chris Packham , linus.walleij@linaro.org, bgolaszewski@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191024202703.8017-1-chris.packham@alliedtelesis.co.nz> From: Scott Branden Message-ID: <12a8ace7-f69d-4002-0146-e84a62b8fd69@broadcom.com> Date: Thu, 24 Oct 2019 13:36:23 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191024202703.8017-1-chris.packham@alliedtelesis.co.nz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch Series looks ok. On 2019-10-24 1:27 p.m., Chris Packham wrote: > This is ported this from Broadcom's XLDK (now heavily modified). There seem to > be 3 different IP blocks for 3 separate banks of GPIOs in the iProc chips. > > I've dropped everything except support for the Chip Common A GPIO > controller because the other blocks actually seem to be supportable with > other drivers. The driver itself is halfway between pinctrl-nsp-gpio.c > and pinctrl-iproc-gpio.c. > > Chris Packham (2): > dt-bindings: gpio: brcm: Add bindings for xgs-iproc > gpio: Add xgs-iproc driver Acked-by: Scott Branden > > .../bindings/gpio/brcm,xgs-iproc-gpio.yaml | 70 ++++ > drivers/gpio/Kconfig | 9 + > drivers/gpio/Makefile | 1 + > drivers/gpio/gpio-xgs-iproc.c | 321 ++++++++++++++++++ > 4 files changed, 401 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc-gpio.yaml > create mode 100644 drivers/gpio/gpio-xgs-iproc.c >