From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbdIEIET (ORCPT ); Tue, 5 Sep 2017 04:04:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:39234 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751630AbdIEIED (ORCPT ); Tue, 5 Sep 2017 04:04:03 -0400 Subject: Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC To: Alexandre Belloni Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roc He , =?UTF-8?B?6JKL5Li955C0?= , Alessandro Zummo , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, Andrew Lunn References: <20170904225324.29138-1-afaerber@suse.de> <20170905075900.wsroxyp6mzdzjclu@piout.net> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <12aac585-64f4-f08b-c5bf-b1f0ac124924@suse.de> Date: Tue, 5 Sep 2017 10:03:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170905075900.wsroxyp6mzdzjclu@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 05.09.2017 um 09:59 schrieb Alexandre Belloni: > On 05/09/2017 at 00:53:21 +0200, Andreas Färber wrote: >> Hello, >> >> This series adds the RTC for the Realtek RTD1295 SoC. >> Based on my RTD1295 clk series. >> >> There being no public source code for RTD1295, the implementation is based on >> register offsets seen in the vendor DT, as well as older mach-rtk119x code >> published by QNAP. >> >> v4 adds a missing clk_put(). >> >> The DT node depends on the clk series for clock index and header. >> >> More experimental patches at: >> https://github.com/afaerber/linux/commits/rtd1295-next >> >> Have a lot of fun! >> >> Cheers, >> Andreas >> >> v3 -> v4: >> * Added clk_put() (Alexandre) >> >> v2 -> v3: >> * Dropped spinlock (Andrew) >> * Improved year_days vs. days_in_year readability >> >> v1 -> v2: >> * Updated rtc driver to no longer use open/release (Alexandre) >> * Cleaned up debug output (Andrew) >> * Avoided COMPILE_TEST division errors (kbuild) >> * Various cleanups and extensions >> >> Cc: Alessandro Zummo >> Cc: Alexandre Belloni >> Cc: linux-rtc@vger.kernel.org >> Cc: Roc He >> Cc: 蒋丽琴 >> Cc: devicetree@vger.kernel.org >> Cc: Andrew Lunn >> >> Andreas Färber (3): >> dt-bindings: rtc: Add Realtek RTD1295 >> rtc: Add Realtek RTD1295 >> arm64: dts: realtek: Add RTD1295 RTC node >> >> .../devicetree/bindings/rtc/realtek,rtd119x.txt | 16 ++ >> arch/arm64/boot/dts/realtek/rtd1295.dtsi | 6 + >> drivers/rtc/Kconfig | 8 + >> drivers/rtc/Makefile | 1 + >> drivers/rtc/rtc-rtd119x.c | 242 +++++++++++++++++++++ >> 5 files changed, 273 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt >> create mode 100644 drivers/rtc/rtc-rtd119x.c >> > Applied, thanks. Err, I am hoping you only queued patches 1-2? Please do not queue patch 3, that needs to go through my tree as per the comments - it will not build. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)