From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbdIEJWv (ORCPT ); Tue, 5 Sep 2017 05:22:51 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5966 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdIEJWt (ORCPT ); Tue, 5 Sep 2017 05:22:49 -0400 Subject: Re: [PATCH] arm64: Convert pr_warning to standard pr_warn To: Mark Rutland CC: , , References: <1504578518-77544-1-git-send-email-cj.chengjian@huawei.com> <20170905091051.GA4401@leverpostej> From: "chengjian (D)" Message-ID: <12ad3ebb-191b-b753-a773-250b0992f1c2@huawei.com> Date: Tue, 5 Sep 2017 17:22:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170905091051.GA4401@leverpostej> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.219.85] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.59AE6CE0.005D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e8821d834633db1932ab004ba174c22d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, OK, I will do it now > On Tue, Sep 05, 2017 at 10:28:38AM +0800, chengjian c00427203 wrote: >> Convert pr_warning to standard pr_warn in arch/arm64/kernel/smp.c >> >> Signed-off-by: Cheng Jian >> --- >> arch/arm64/kernel/smp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > Is this a step towards removing pr_warning entirely? > > If so, can you please fix up all occurences in arm64? i.e. > > [mark@leverpostej:~/src/linux]% git grep pr_warning linux-next/master:arch/arm64 > linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n", > linux-next/master:arch/arm64:include/asm/syscall.h: pr_warning("%s called with max args %d, handling only %d\n", > linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("unknown slot type: %d\n", type); > linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to read from unknown breakpoint register %d\n", n); > linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("attempt to write to unknown breakpoint register %d\n", n); > linux-next/master:arch/arm64:kernel/hw_breakpoint.c: pr_warning("invalid breakpoint privilege level %d\n", privilege); > linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", > linux-next/master:arch/arm64:kernel/smp.c: pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", > > Otherwise, I don't think it make sense to only fix some occurences. > > Thanks, > Mark. > >> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c >> index 9f7195a..efcaa05 100644 >> --- a/arch/arm64/kernel/smp.c >> +++ b/arch/arm64/kernel/smp.c >> @@ -972,7 +972,7 @@ void smp_send_stop(void) >> udelay(1); >> >> if (num_online_cpus() > 1) >> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", >> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", >> cpumask_pr_args(cpu_online_mask)); >> } >> >> @@ -1009,7 +1009,7 @@ void crash_smp_send_stop(void) >> udelay(1); >> >> if (atomic_read(&waiting_for_crash_ipi) > 0) >> - pr_warning("SMP: failed to stop secondary CPUs %*pbl\n", >> + pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", >> cpumask_pr_args(&mask)); >> } >> >> -- >> 1.8.3.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > . >