From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>,
zhenwei pi <pizhenwei@bytedance.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] misc: pvpanic: introduce device capability
Date: Fri, 8 Jan 2021 12:43:11 +0100 [thread overview]
Message-ID: <12aebc37-aaba-2ed2-d944-c80eeac6f052@redhat.com> (raw)
In-Reply-To: <X/hB7ejy7XtjNO68@kroah.com>
On 08/01/21 12:28, Greg KH wrote:
>> static void __iomem *base;
>> +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED;
>> +module_param(capability, uint, 0444);
>> +MODULE_PARM_DESC(capability, "capability of pvpanic device");
> This is not the 1990's, please do not add new module parameters:(
Note that the parameter can also be used to _limit_ which capabilities
the driver uses:
v1:
> + /* initlize capability by RDPT */
> + capability = ioread8(base);
v2:
> + /* initlize capability by RDPT */
> + capability &= ioread8(base);
Of course it would have helped if there was a summary of v1->v2 changes
in the message. :)
Paolo
> Use sysfs, and properly document the file in Documentation/ABI/
prev parent reply other threads:[~2021-01-08 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 11:17 zhenwei pi
2021-01-08 11:26 ` Greg KH
2021-01-08 11:28 ` Greg KH
2021-01-08 11:43 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12aebc37-aaba-2ed2-d944-c80eeac6f052@redhat.com \
--to=pbonzini@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®