From: Andrew Lunn <andrew@lunn.ch>
To: Hongmei Xu <hongmei.xu@oss.qualcomm.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sagar Cheluvegowda <sagar.cheluvegowda@oss.qualcomm.com>
Subject: Re: [PATCH net-next] net: phy: aquantia: Poll global status register for provision ID
Date: Thu, 29 Oct 2026 14:35:06 +0100 [thread overview]
Message-ID: <12b07a59-c087-4ba2-8d5e-40b2a6d6a72a@lunn.ch> (raw)
In-Reply-To: <20261029-aquantia-poll-global-status-register-v1-1-808089824a3d@oss.qualcomm.com>
On Thu, Oct 29, 2026 at 05:28:10PM +0800, Hongmei Xu wrote:
> After the firmware reset sequence completes, the global reserved status
> register (VEND1_GLOBAL_RSVD_STAT1) may not yet contain a valid provision
> ID. This can cause subsequent firmware operations to proceed with stale
> state.
>
> Poll VEND1_GLOBAL_RSVD_STAT1 until the provision ID field is non-zero
> before returning from aqr_wait_reset_complete(). A timeout is treated as
> a non-fatal warning since the PHY can still function without a valid
> provision ID.
If it can still work without the provisioning ID, why bother reading
it?
Maybe extend the commit message saying what features will be missing
if there is no ID.
It looks like USXGMII and 10G-QXGMII might be mixed up? Is such a mix
up not fatal?
Andrew
next prev parent reply other threads:[~2026-10-29 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 9:28 Hongmei Xu
2026-10-29 13:35 ` Andrew Lunn [this message]
2026-10-29 9:30 netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b07a59-c087-4ba2-8d5e-40b2a6d6a72a@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hongmei.xu@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sagar.cheluvegowda@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®