From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC3D38E5F2; Thu, 26 Feb 2026 07:26:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772090788; cv=none; b=B9VM0GpljC0uW1uGkMv1mmpJlXJy/RBwQqDdbzjvZ/UkZsIFP799HcBrIYWavGVG4t07KN+QTpomnD0xeJAZW/J20Yt8Um54OWkECtm2/30OulgqIHyP7HnkQHR7k0/BHstWTQzwZHzd9j0wbYqFAFAIAdy8XYBmeoaPwG0iJGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772090788; c=relaxed/simple; bh=d1ekx1O5rk7AZ28cppYV6jduPZz+ymIMOkMNMxR+F0c=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=pBpYKV+kPPWb/vZda1JkW1mGNhVph5SIcwKUt8bGoEwLx9Gur/FQOlxuh2nxcQNh1CunvRBryaqSlXVxxlLCh7SYNu1gDqkO4WSqt8QSLWBvOerX01cKoeUO66v7BN2Moww4WqoBrgdGbafLJRJKARMJKctRYuEhE2Abp6JNieg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fWZw6IPQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fWZw6IPQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39EEDC19422; Thu, 26 Feb 2026 07:26:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772090787; bh=d1ekx1O5rk7AZ28cppYV6jduPZz+ymIMOkMNMxR+F0c=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=fWZw6IPQAcBhOy3gZVNfFG1YmojfNnGVLmSd2X3yl+O0qQ3C4ees5x8un4OndWu79 zuvzGS0L0S3Pxl3upIepa7hUrdZKqjdU9NBJWYSQbpeorj2njazwv7Swzj97xtw+Me 3VZQ9V/0Nr0Yds/czAlIlbbxAGHMptEpOpCLVVuxu6bTBGnTxslyVokNq4Kp9xa6rJ /WoSq6Q4OL3xFkOZtapF2y4n0tt3H0QwLkS8YXCIghTXdbYdyM0vSI7PtahiPpMTYE oRXwXVzZdyoz9l/lGuN4Miisg8y+k9vgw/QtHnDw8ywC2Dwb4cqol7fJFgHwqUmdGN JrNgaol/63YXw== Message-ID: <12b30229-1c55-429d-8a3c-0d831c4d33ab@kernel.org> Date: Thu, 26 Feb 2026 08:26:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88} From: Krzysztof Kozlowski To: Cristian Ciocaltea Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Detlev Casanova , Ezequiel Garcia , Mauro Carvalho Chehab , Nicolas Dufresne , Hans Verkuil , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Conor Dooley , linux-media@vger.kernel.org References: <20260225-vdec-reg-order-rk3576-v3-0-5a2ebe1b11a8@collabora.com> <20260225-vdec-reg-order-rk3576-v3-1-5a2ebe1b11a8@collabora.com> <9bb74438-e759-46a7-9fa1-2c6b1fced76b@kernel.org> <85793250-425d-40da-b382-ada9fc7b50e1@kernel.org> <72a72c50-4816-47d4-b533-be4b7feee027@collabora.com> <20260226-screeching-manatee-of-amplitude-6dfbf6@quoll> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260226-screeching-manatee-of-amplitude-6dfbf6@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/02/2026 08:25, Krzysztof Kozlowski wrote: > On Thu, Feb 26, 2026 at 12:26:37AM +0200, Cristian Ciocaltea wrote: >>>> Sorry, but I don't quite get why would this be a better approach than just >>>> properly list the items according to the HW layout, i.e. following the >>>> address-based ordering? >>> >>> We always expect the list to grow, to have common set. That's rule given >>> during reviews multiple times. For multiple reasons, also explained >>> (consistency, maintenance and actually proper description of hardware >>> like the main reg address space). >>> >>> Probably this was also given to that binding during discussions when it >>> was upstream, so your change reverts previous discussion and to that I >>> do not agree. >> >> Thank you for detailing this, I get your point now. >> >> After digging a bit further, it looks like the "function" naming has been >> introduced as part of the RK3588 support via commit c6ffb7e1fb90 ("media: >> dt-bindings: rockchip: Document RK3588 Video Decoder bindings"). >> >> Morever, it also sets `reg-names: false` for all the SoCs other than RK3588 - >> sorry for missing this initially. >> >> Hence "function" wasn't used at all in the context of the older SoCs, while on >> RK3588 & RK3576 there is no indication that "function" should be treated as the >> main address space or anything like that. E.g. RK3588 TRM clearly shows the >> "link" range at the top of the listing, starting at video decoder unit base >> address: >> >> -------------------------------------------------------------------------------- >> Config Register | Base addr >> -------------------------------------------------------------------------------- >> VDPU381 core0/1 link table config base | VDPU381_core0/1_base+0x000 >> VDPU381 core0/1 function config base | VDPU381_core0/1_base+0x100 >> -------------------------------------------------------------------------------- >> | VDPU381_core0/1_base+0x600 for Y channel >> VDPU381 core0/1 cache config base | VDPU381_core0/1_base+0x640 for C channel >> | VDPU381_core0/1_base+0x680 for head channel >> -------------------------------------------------------------------------------- >> >> Assuming the reasoning above is now good enough to move further with the >> proposed approach, I can prepare a new revision dropping the unnecessary >> one-entry item from the reg-names, while keeping all the rest in the series as >> is. > > Yes, with drop of the oneOf this would be fine. I meant, the "one item option" in oneOf. Best regards, Krzysztof