From: Philipp Zabel <p.zabel@pengutronix.de>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: "open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
John Crispin <john@phrozen.org>,
linux-staging@lists.linux.dev,
Greg KH <gregkh@linuxfoundation.org>, NeilBrown <neil@brown.name>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH v6 3/4] clk: ralink: make system controller node a reset provider
Date: Mon, 10 Jan 2022 11:23:33 +0100 [thread overview]
Message-ID: <12b7e367e8323f6da7bb548dbbae0d342608e52b.camel@pengutronix.de> (raw)
In-Reply-To: <CAMhs-H_gjW_6p6yBWf+k2PBym4N+k+rBEXR9S8c13NU-UWD4VQ@mail.gmail.com>
On Mon, 2022-01-10 at 10:39 +0100, Sergio Paracuellos wrote:
[...]
> > Is this known to work for all possible users, without delay between
> > assert and deassert?
>
> It seems it is. This is based on the original reset implementation for
> ralink. See:
>
> https://elixir.bootlin.com/linux/v5.16/source/arch/mips/ralink/reset.c#L55
>
> > Are there any users of the reset_control_reset() API at all? This API
> > was added for self-clearing reset bits, so if there are no users that
> > need to pretend this is a reset pulse at the hardware level (there may
> > be), I'd prefer if this was just left out.
>
> I am not following you here. What do you mean?
Looking at drivers/staging/mt7621-dts/mt7621.dtsi, it appears the
current reset users are:
mediatek,mt7621-i2c
ralink,mt7621-spi
ralink,rt3883-gdma
mediatek,mt7621-hsdma
mediatek,mt7621-eth
mediatek,mt7621
mediatek,mt7621-pci
Many of the corresponding drivers use device_reset(), which is a
shorthand for requesting a reset control and calling
reset_control_reset() on it. That will call mt7621_reset_device, so it
is indeed used.
regards
Philipp
next prev parent reply other threads:[~2022-01-10 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 8:39 [PATCH v6 0/4] clk: ralink: make system controller " Sergio Paracuellos
2022-01-10 8:39 ` [PATCH v6 1/4] dt-bindings: reset: add dt binding header for Mediatek MT7621 resets Sergio Paracuellos
2022-01-10 8:39 ` [PATCH v6 2/4] dt-bindings: clock: mediatek,mt7621-sysc: add '#reset-cells' property Sergio Paracuellos
2022-01-10 8:39 ` [PATCH v6 3/4] clk: ralink: make system controller node a reset provider Sergio Paracuellos
2022-01-10 9:13 ` Philipp Zabel
2022-01-10 9:39 ` Sergio Paracuellos
2022-01-10 10:23 ` Philipp Zabel [this message]
2022-01-10 10:59 ` Sergio Paracuellos
2022-01-10 8:39 ` [PATCH v6 4/4] staging: mt7621-dts: align resets with binding documentation Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12b7e367e8323f6da7bb548dbbae0d342608e52b.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=john@phrozen.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=neil@brown.name \
--cc=sboyd@kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®