From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82644183CAD; Tue, 13 Aug 2024 09:42:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723542122; cv=none; b=tMOcSi7IJkRchHl1O9TalvPZzrmOh652JfHVq0KzkqeWOPz0xL+NY30fOlS5HDVo/NYSr30koIneP/ei4/7KxZ3oO1JaB6ptouK8RX/TrzX7mPJmdwYjN6IbGSjBKqC1hFPsggnpeH0eN6gj70XpMd9XXLuLkOI7lz245mUhn2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723542122; c=relaxed/simple; bh=lqnWFnGXEbRQdDNV6/VYyCoDRdrnqpfZzHdXdr1V1p4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uhQVGvnzt5iyzne8PEOgHaHdOHeSjxbSSWsnHwLWtoOXAYwSZj23tPvZb0PPfDViWhW61lttCufra4Iaw0fVaUQBR3yUW7E97/jkQ5CdaxeCr/EzjXEbLa3tgS4W08eXbo2HxhNr6UgNSaDb2JZIYM9VzIISb97ymqmJBOW7LpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ifiMyxZs; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=y8ZsKrMt; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=ifiMyxZs; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=y8ZsKrMt; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ifiMyxZs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="y8ZsKrMt"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="ifiMyxZs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="y8ZsKrMt" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A5E082272C; Tue, 13 Aug 2024 09:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723542118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FE5no6wq38CpWswWx2uoo4/gsjYvCTGI7gMAOBb4YS8=; b=ifiMyxZsOkp+pjyu2jCxMc1kcA1fuJtRpzCKtdkwDndw5N/XHk95hgiV+0Ud/MDhXxyB/C 3oYudBYpKM3X++RgFYZ+8/TXpccriQsYJ6PzFtnycSSCuLK8O3WEFwpoY8Vo+27ZpybE5u C29l2hFLcd3Ovqd/VHEzut4Ck9aKE4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723542118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FE5no6wq38CpWswWx2uoo4/gsjYvCTGI7gMAOBb4YS8=; b=y8ZsKrMtpi6Rs3i2ujWlOwlVrIu/gtEuF1KEMC6tVQmjUT/bMVFXpTxFrMIgTE2KcdmukZ 8+8zBHeaMzq7PYAg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ifiMyxZs; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=y8ZsKrMt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723542118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FE5no6wq38CpWswWx2uoo4/gsjYvCTGI7gMAOBb4YS8=; b=ifiMyxZsOkp+pjyu2jCxMc1kcA1fuJtRpzCKtdkwDndw5N/XHk95hgiV+0Ud/MDhXxyB/C 3oYudBYpKM3X++RgFYZ+8/TXpccriQsYJ6PzFtnycSSCuLK8O3WEFwpoY8Vo+27ZpybE5u C29l2hFLcd3Ovqd/VHEzut4Ck9aKE4k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723542118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FE5no6wq38CpWswWx2uoo4/gsjYvCTGI7gMAOBb4YS8=; b=y8ZsKrMtpi6Rs3i2ujWlOwlVrIu/gtEuF1KEMC6tVQmjUT/bMVFXpTxFrMIgTE2KcdmukZ 8+8zBHeaMzq7PYAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8CFF913ABD; Tue, 13 Aug 2024 09:41:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NYNnImYqu2bxSwAAD6G6ig (envelope-from ); Tue, 13 Aug 2024 09:41:58 +0000 Date: Tue, 13 Aug 2024 11:41:57 +0200 From: Daniel Wagner To: Christoph Hellwig Cc: Jens Axboe , Keith Busch , Sagi Grimberg , Thomas Gleixner , "Martin K. Petersen" , John Garry , "Michael S. Tsirkin" , Jason Wang , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Sathya Prakash Veerichetty , Suganath Prabu Subramani , Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, Jonathan Corbet , Frederic Weisbecker , Mel Gorman , Hannes Reinecke , Sridhar Balaraman , "brookxu.cn" , Ming Lei , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, virtualization@lists.linux.dev, megaraidlinux.pdl@broadcom.com, mpi3mr-linuxdrv.pdl@broadcom.com, MPT-FusionLinux.pdl@broadcom.com, storagedev@microchip.com, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 07/15] blk-mq: remove unused queue mapping helpers Message-ID: <12ba2ff0-b8c9-46b3-bea0-56304cf7a7dc@flourine.local> References: <20240806-isolcpus-io-queues-v3-0-da0eecfeaf8b@suse.de> <20240806-isolcpus-io-queues-v3-7-da0eecfeaf8b@suse.de> <20240812090848.GH5497@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240812090848.GH5497@lst.de> X-Spam-Score: -5.01 X-Rspamd-Queue-Id: A5E082272C X-Spamd-Result: default: False [-5.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_TWELVE(0.00)[34]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.dk,kernel.org,grimberg.me,linutronix.de,oracle.com,redhat.com,broadcom.com,marvell.com,lwn.net,suse.de,parallelwireless.com,gmail.com,vger.kernel.org,lists.infradead.org,lists.linux.dev,microchip.com]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; TAGGED_RCPT(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLbomrtoisjzkgzhj6iko5ju7u)]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Flag: NO On Mon, Aug 12, 2024 at 11:08:48AM GMT, Christoph Hellwig wrote: > On Tue, Aug 06, 2024 at 02:06:39PM +0200, Daniel Wagner wrote: > > * Copyright (c) 2016 Christoph Hellwig. > > None of my code left at this point :) I do my best to reduce code :) > > /** > > * blk_mq_pci_get_queue_affinity - get affinity mask queue mapping for PCI device > > * @dev_data: Pointer to struct pci_dev. > > But on to something more substancial: thes get_queue_affinity > wrappers have nothing specific in them. So maybe move them into > the PCI and virtio subsystems instead and kill off these files > entirely. Make sense!