From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFC933321C2 for ; Tue, 18 Nov 2025 10:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763460720; cv=none; b=qFuTip6noU9mZ3ynXggWZ2hFoba0SWXYcvIMqpS1Oc3jdvlP4VVQzQaIrSDH9cZLRnsPbrn81PWBFLDSw33kPFJsA2EdCgq/3tchKtXiL5Cyw74nwlSLa7Aqa7TkN+YV20eVZwPPVnuen446kCmDp4b7NIL5pQ630fkmsSx1NK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763460720; c=relaxed/simple; bh=2k8kp2eCR6II4n4tUCL2G0L3QQg9MS54ilVfxnRiAaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lzFUxDrfINnt77IKKcvII54goIAln/bDdOOXf9N+ArLIYA8STMfONSXynSKtZcoMRtNBvgnsDvFMLmTvzRaHCljAwiSiIxzjUGvW/QJWC+FH3LHlgKX46B5svxzUHKrO1YJu9vP77K0gWVIM8pUJNCbvBlAMuGsjMyU5eA//zFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nQGnFtnr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IPUyin9w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nQGnFtnr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IPUyin9w" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI6fOib2272031 for ; Tue, 18 Nov 2025 10:11:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KsUDUPxoq1t6MjKduGIYJdoPPwEgISWzAZ7LFsDaIFs=; b=nQGnFtnrJESm64mR 9pEc4QGS9+y/0mQ5OuNcwYcNBN7K9xcBXlAZDMp3AESCmTFz6V4EtRyMRhEok4FE LJlTT7GbrrR5JD/PzKyzc1ItEtLZtrnFYMd3p1CStYB1LamauxsLJ/Vxu9dE6eWk sNGBuKh/xOWdXERN2tINpi6JyN7Z499XZZ7UF37dVO74mRhpBy4BVbzX6Slp8a/k vVDWFOIGBUuoT4WZ+dC3O2E09RSTsmIUOQA3YrwJZmz8zBS8PkEbCE/SyB3PW+3g iHXBEcNt1S3G0aV7cwlkcczhwsXkck9+4QYTxIP5O3gPGA81pEQJCyhpNgsHHus7 FctMpg== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agkrmgmks-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 10:11:57 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-299ddb0269eso28020345ad.0 for ; Tue, 18 Nov 2025 02:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763460717; x=1764065517; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KsUDUPxoq1t6MjKduGIYJdoPPwEgISWzAZ7LFsDaIFs=; b=IPUyin9wB/Vj6H+ZgeTe7FQvnCbZtFe/t9i3L99WcMLdy2R/Zx5bSXNIeLW3qGU3j/ vM207TqagJu3qEpYf88CvI3fbvtYxsOLkZqZoElD7CGPDxVSONqMalsc0doQ7oY8CLk9 IjH/QoCZqyXhwFrJX25541VFH2HfdcEBKf6IQzsIZj+PKtSO9v/B1Y9SG5r5sdspQPOY AqttR7Ya6kSzqpzyk8vQ1Q1mUs09vs+g7hd7/atZnOR2PQ1tHeI+tPJtDbOtn3dQv+f3 irSaGjRVa02XCYYFqjIZ2Nk9pbBfzOxpRn1K2d7szCD+DAMKfUmns3MZjhG1b90NZtyD CirQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763460717; x=1764065517; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KsUDUPxoq1t6MjKduGIYJdoPPwEgISWzAZ7LFsDaIFs=; b=UYOcGyAhbJgusL53ZWFfBkTCOeYlbdz/RUVL1uo654EX2By8FFfbGeop2x9EXCA4cU zjV9L4wRo+DP9T/Cr0UBq7miLQb4zgJ3/zz6/fxTM/yKF9Vu2QcjzSeWmwRvQKm0rWIV e4hy+uASGFPXeHvj94S036D1PQzrl0vf0pzm5HUO8czjF64qQkQTl0cQz6cCVwqMrqI4 +71lY0QT9BKEGVCSm67GV1alW2VwhKtgLwshdUMUvVeuek4A+sM0sHLJ6kUatcISAjdm breHub2zerACe9uxU509x4SyGlQTvBtZK3CmNxLjYwXqZyfOz62GtIevDsyP19oDOw7x yKSw== X-Forwarded-Encrypted: i=1; AJvYcCWbDs8zKBat2vINx3CiL3EGm8tWmXmU+U4V7qVK+ZEEg4+dn915RxbeS4lKAbG6Q1LciZfNlqFix81R6Z0=@vger.kernel.org X-Gm-Message-State: AOJu0YxjLaSdMhlLKgq1S04wOLL1UxTi0LV64HuGS6bSbXt0Fa8Z4/dD 24od8D+R6q57PGdSj7Iwu0ks/SLBDfEU9cVL/4IzVmHgApMd/gwi76NGYsfzOlTvr2dAOQypdw/ o43KZdB/xbyCCo52pUVGIT0L+bLBdUeoVFEB9LpfDkRrN1WbnIHj/VWDa05J37zpoV+s= X-Gm-Gg: ASbGncvUf6rKtDPeeoBLXe5WzOCp1Kc3l0zbm9F7afeqjxodakF0x1b+NTNBvGCzwCp gJI49vKc2ztT97mnIgQ8s9AoxTvOHdT6uMfRzpzYdpwtb0W5WUKIMruwFqkB2cRwzoei+PU4GZd gdlqxZKGF0BoEuFVme14MSqFLWXJ0NvRQTJ31X9YH94LTwEOw7C9t5J2PTmKeaVlMAbCG5agLNj q4H8lcmZxCx2kfnRjVCOpQVws4cNJ15Z4w/gJkdhIOgzO9sO0EZUdK2X1c2cxZVtwS8FY0P29r/ kMqP+DRBGDkBd3JkYBRpXma3CWRABS1X6d8ng6VGwYfd5AfIT/T3K9UG6KBc3H6Eo3a1IO7YzQw CcEJGqZFNJg4wRMkxqg8tuHNqYBkr734iBMrp8MXYxQZqXNRc+TJK6xPWncVXhEXj X-Received: by 2002:a17:902:f647:b0:298:42ba:c422 with SMTP id d9443c01a7336-2986a73303amr176999555ad.31.1763460716847; Tue, 18 Nov 2025 02:11:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSElhq/foZIVZg0t4wjamD5rzsGK+/4gwbgY+RGs+mSFiFVT1jM6xTJZ07fGy9cGHEujc8lw== X-Received: by 2002:a17:902:f647:b0:298:42ba:c422 with SMTP id d9443c01a7336-2986a73303amr176999195ad.31.1763460716345; Tue, 18 Nov 2025 02:11:56 -0800 (PST) Received: from [10.133.33.100] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2986e5ef32asm133115195ad.39.2025.11.18.02.11.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 02:11:56 -0800 (PST) Message-ID: <12bce4de-9491-4040-991b-529bc916983c@oss.qualcomm.com> Date: Tue, 18 Nov 2025 18:11:47 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: Add PCIe3 and PCIe5 regulators for HAMAO-IOT-EVK board To: Dmitry Baryshkov Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, johan+linaro@kernel.org, vkoul@kernel.org, kishon@kernel.org, neil.armstrong@linaro.org, abel.vesa@linaro.org, kw@linux.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, qiang.yu@oss.qualcomm.com, krishna.chundru@oss.qualcomm.com, quic_vbadigan@quicinc.com References: <20251112090316.936187-1-ziyue.zhang@oss.qualcomm.com> <20251112090316.936187-3-ziyue.zhang@oss.qualcomm.com> Content-Language: en-US From: Ziyue Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDA4MSBTYWx0ZWRfX4W/SKX6w3tbz 1QG75l2wn4vV+xMRmSdu78h2+T4arSgqbObrgzfc1Uw0TUQdD2XnsmKCB7mEIGwzvNEDVF5j483 22gGXJv6xMDLQWvSpvbXmfpX1A3jiYF02be4+I4Ktk2Q5Wi8kf6ltmc0nXXYBlSpYjro6VH3Fl5 eF1QdVB8q7JyXRXw4aFG9zNKYaMo+4eazXgN7rqSpF5wSrioMSOCSkiNvvtXMNl6LsasmhzU9PH 2ZGjeQexSfLUBJ7FZdN+lIPtqDo6tquQidSlVMDtOyxkid/If6ALYoia2F67ez1+8H2S8cN4dGu zoR7wGHKLYUnmM7bpZmaMLVyFQP68rJxjbgTelI6Mch+K+lTUgS3wbQNUwis1mLawqjJ7NEQyE6 RgRdaSsYlC/G0xW+DVyfjSF+JPVmaA== X-Proofpoint-ORIG-GUID: lWreV9o9206D1AfXNwQ_tsySvyjhsO7l X-Proofpoint-GUID: lWreV9o9206D1AfXNwQ_tsySvyjhsO7l X-Authority-Analysis: v=2.4 cv=JfWxbEKV c=1 sm=1 tr=0 ts=691c466d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=0FT5JWsqCLsmEzCoxIcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0 impostorscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180081 On 11/13/2025 5:16 AM, Dmitry Baryshkov wrote: > On Wed, Nov 12, 2025 at 05:03:16PM +0800, Ziyue Zhang wrote: >> HAMAO IoT EVK uses PCIe5 to connect an SDX65 module for WWAN functionality >> and PCIe3 to connect a SATA controller. These interfaces require multiple >> voltage rails: PCIe5 needs 3.3V supplied by vreg_wwan, while PCIe3 requires >> 12V, 3.3V, and 3.3V AUX rails, controlled via PMIC GPIOs. >> >> Add the required fixed regulators with related pin configuration, and >> connect them to the PCIe3 and PCIe5 ports to ensure proper power for the >> SDX65 module and SATA controller. >> >> Signed-off-by: Ziyue Zhang >> Reviewed-by: Krishna Chaitanya Chundru >> --- >> arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 83 ++++++++++++++++++++++ >> 1 file changed, 83 insertions(+) >> >> +&pmc8380_3_gpios { >> + pm_sde7_aux_3p3_en: pcie-aux-3p3-default-state { > What is sde7? Other than that: > > > Reviewed-by: Dmitry Baryshkov > Hi Dmitry I’m not sure what “sde7” refers to specifically. I saw this name in the schematic, and the pin is labeled PM_SDE7_AUX_3P3, so I used that naming in the DT. BRs Ziyue > >> + pins = "gpio8"; >> + function = "normal"; >> + output-enable; >> + output-high; >> + bias-pull-down; >> + power-source = <0>; >> + }; >> + >> + pm_sde7_main_3p3_en: pcie-main-3p3-default-state { >> + pins = "gpio6"; >> + function = "normal"; >> + output-enable; >> + output-high; >> + bias-pull-down; >> + power-source = <0>; >> + }; >> +}; >> + >> &pmc8380_5_gpios { >> usb0_pwr_1p15_reg_en: usb0-pwr-1p15-reg-en-state { >> pins = "gpio8"; >> -- >> 2.34.1 >>