From: "Tony Luck" <tony.luck@intel.com>
To: "Arjan van de Ven" <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: PATCH] debug: add notifier chain debugging
Date: Mon, 25 Aug 2008 15:39:13 -0700 [thread overview]
Message-ID: <12c511ca0808251539w6f00a216s86a09a532c553a34@mail.gmail.com> (raw)
In-Reply-To: <20080815152938.4bc9d48c@infradead.org>
On Fri, Aug 15, 2008 at 3:29 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> + if (!kernel_text_address((unsigned long)n->notifier_call)) {
> + WARN(1, "Invalid notifier registered!");
> + return 0;
> + }
This breaks on ia64 (and pa-risc I think) where function pointers don't point
directly at the code, they point to a {code,data} structure which is itself
located in data space, not text space.
-Tony
next prev parent reply other threads:[~2008-08-25 22:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 22:29 Arjan van de Ven
2008-08-15 22:53 ` Ingo Molnar
2008-08-20 4:09 ` Andrew Morton
2008-08-20 10:53 ` Ingo Molnar
2008-08-22 14:00 ` Arjan van de Ven
2008-08-22 14:45 ` Christoph Hellwig
2008-08-25 22:39 ` Tony Luck [this message]
2008-08-26 4:55 ` Arjan van de Ven
2008-08-26 5:08 ` Tony Luck
2008-08-26 13:46 ` Arjan van de Ven
2008-08-26 16:22 ` Arjan van de Ven
2008-08-27 6:39 ` Ingo Molnar
2008-08-27 10:55 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c511ca0808251539w6f00a216s86a09a532c553a34@mail.gmail.com \
--to=tony.luck@intel.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome