mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Luck <tony.luck@intel.com>
To: mingo@redhat.com, hpa@zytor.com, ego@in.ibm.com,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	tglx@linutronix.de, mingo@elte.hu
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] sched: Print sched_group::__cpu_power in  sched_domain_debug
Date: Mon, 13 Apr 2009 11:53:13 -0700	[thread overview]
Message-ID: <12c511ca0904131153g39b99ec6n6c6ec2e7de3f7ea6@mail.gmail.com> (raw)
In-Reply-To: <tip-46e0bb9c12f4bab539736f1714cbf16600f681ec@git.kernel.org>

> --- a/kernel/sched.c
> +++ b/kernel/sched.c
> @@ -6963,7 +6963,8 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
>                cpumask_or(groupmask, groupmask, sched_group_cpus(group));
>
>                cpulist_scnprintf(str, sizeof(str), sched_group_cpus(group));
> -               printk(KERN_CONT " %s", str);
> +               printk(KERN_CONT " %s (__cpu_power = %d)", str,
> +                                               group->__cpu_power);

This has added a lot of clutter to the console log during boot
(especially on large systems).

Here is the start of the diff output comparing old and new console
messages on a 16 cpu machine:

77c77
<   groups: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
---
>   groups: 0 (__cpu_power = 1024) 1 (__cpu_power = 1024) 2 (__cpu_power = 1024) 3 (__cpu_power = 1024) 4 (__cpu_power = 1024) 5 (__cpu_power = 1024) 6 (__cpu_power = 1024) 7 (__cpu_power = 1024) 8 (
__cpu_power = 1024) 9 (__cpu_power = 1024) 10 (__cpu_power = 1024) 11
(__cpu_power = 1024) 12 (__cpu_power = 1024) 13 (__cpu_power = 1024)
14 (__cpu_power = 1024) 15 (__cpu_power = 1024)
80c80
<   groups: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 0
---
>   groups: 1 (__cpu_power = 1024) 2 (__cpu_power = 1024) 3 (__cpu_power = 1024) 4 (__cpu_power = 1024) 5 (__cpu_power = 1024) 6 (__cpu_power = 1024) 7 (__cpu_power = 1024) 8 (__cpu_power = 1024) 9 (
__cpu_power = 1024) 10 (__cpu_power = 1024) 11 (__cpu_power = 1024) 12
(__cpu_power = 1024) 13 (__cpu_power = 1024) 14 (__cpu_power = 1024)
15 (__cpu_power = 1024) 0 (__cpu_power = 1024)

continues as each group is reported.

-Tony

  reply	other threads:[~2009-04-13 18:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-30  4:55 [PATCH] " Gautham R Shenoy
2009-03-30  4:55 ` Gautham R Shenoy
2009-04-01 16:03   ` [tip:sched/urgent] " Gautham R Shenoy
2009-04-13 18:53     ` Tony Luck [this message]
2009-04-14  0:09       ` Ingo Molnar
2009-04-14  3:39         ` Gautham R Shenoy
2009-04-14 12:03           ` [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case tip-bot for Gautham R Shenoy
2009-04-14 16:29           ` [tip:sched/urgent] sched: Print sched_group::__cpu_power in sched_domain_debug Luck, Tony
2009-04-14 17:06             ` Gautham R Shenoy
2009-04-14 17:18               ` Luck, Tony
2009-04-14 18:40                 ` Ingo Molnar
2009-04-14 18:42           ` [tip:sched/urgent] sched: Avoid printing sched_group::__cpu_power for default case tip-bot for Gautham R Shenoy
2009-04-16 22:48           ` tip-bot for Gautham R Shenoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c511ca0904131153g39b99ec6n6c6ec2e7de3f7ea6@mail.gmail.com \
    --to=tony.luck@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ego@in.ibm.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome