mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Dale Whinham <daleyo@gmail.com>
Cc: "Maximilian Luz" <luzmaximilian@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"Jérôme de Bretagne" <jerome.debretagne@gmail.com>
Subject: Re: [PATCH 2/3] platform/surface: aggregator_registry: Fix tablet-mode detection on Surface Pro 11
Date: Fri, 18 Sep 2026 20:15:44 +0300 (EEST)	[thread overview]
Message-ID: <12c85dbe-4453-8a38-bd37-cd5f5e97f784@linux.intel.com> (raw)
In-Reply-To: <20260829-surface-pro-11-aggregator-registry-fixes-v1-2-ebf5cca9d205@gmail.com>

On Sat, 29 Aug 2026, Dale Whinham wrote:

> Replace ssam_node_kip_tablet_switch with ssam_node_pos_tablet_switch, as
> Surface Pro 11 reports tablet-mode via the POS ('posture') subsystem and
> not the KIP subsystem.
> 
> The KIP-based driver would remain stuck in a 'folded-back' state after
> suspend/resume, whereas the POS-based device reports its state correctly
> even after suspend/resume.
> 
> This fixes the type cover keyboard/mouse being ignored by desktop
> environments after resume from sleep due to the erroneous 'folded-back'
> state.
> 
> Signed-off-by: Dale Whinham <daleyo@gmail.com>

Please add Fixes tags to this and patch 1 and send v2.

--
 i.

> ---
>  drivers/platform/surface/surface_aggregator_registry.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/surface/surface_aggregator_registry.c b/drivers/platform/surface/surface_aggregator_registry.c
> index 82c2144e10ec..2cb8278d98ea 100644
> --- a/drivers/platform/surface/surface_aggregator_registry.c
> +++ b/drivers/platform/surface/surface_aggregator_registry.c
> @@ -415,7 +415,7 @@ static const struct software_node *ssam_node_group_sp11[] = {
>  	&ssam_node_hid_kip_penstash,
>  	&ssam_node_hid_kip_touchpad,
>  	&ssam_node_hid_kip_fwupd,
> -	&ssam_node_kip_tablet_switch,
> +	&ssam_node_pos_tablet_switch,
>  	NULL,
>  };
>  
> 
> 

  reply	other threads:[~2026-09-18 17:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 18:32 [PATCH 0/3] SSAM registry fixes for " Dale Whinham
2026-08-29 18:32 ` [PATCH 1/3] platform/surface: aggregator_registry: Remove sensors device " Dale Whinham
2026-08-29 18:32 ` [PATCH 2/3] platform/surface: aggregator_registry: Fix tablet-mode detection on " Dale Whinham
2026-09-18 17:15   ` Ilpo Järvinen [this message]
2026-08-29 18:32 ` [PATCH 3/3] platform/surface: aggregator_registry: Add performance profile and fan support for " Dale Whinham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12c85dbe-4453-8a38-bd37-cd5f5e97f784@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=daleyo@gmail.com \
    --cc=hansg@kernel.org \
    --cc=jerome.debretagne@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®