mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Simon Horman <horms@kernel.org>, Daniil Dulov <d.dulov@aladdin.ru>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] can: softing: remove redundant NULL check
Date: Fri, 16 Feb 2024 20:47:43 +0100	[thread overview]
Message-ID: <12cd0fd0-be86-4af0-8d6b-85d3a81edd2a@hartkopp.net> (raw)
In-Reply-To: <20240216172701.GP40273@kernel.org>

Hi Simon,

I have a general question on the "Fixes:" tag in this patch:

On 16.02.24 18:27, Simon Horman wrote:
> On Sun, Feb 11, 2024 at 07:05:35AM -0800, Daniil Dulov wrote:
>> In this case dev cannot be NULL, so remove redundant check.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")

IMHO this is simply an improvement which is done by all patches applied 
to the kernel but it does not really "fix" anything from a functional 
standpoint.

Shouldn't we either invent a new tag or better leave it out to not 
confuse the stable maintainers?

Best regards,
Oliver

>> Signed-off-by: Daniil Dulov <d.dulov@aladdin.ru>
> 
> Hi Daniil,
> 
> I am not sure that dev cannot be NULL.
> But I do see that the code assumes it is not, and would crash if it is.
> So I think that, functionally, your statement is correct.
> 
> 	priv = netdev_priv(dev);
> 	card = priv->card;
> 
> Reviewed-by: Simon Horman <horms@kernel.org>
> 

  reply	other threads:[~2024-02-16 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-11 15:05 Daniil Dulov
2024-02-16 17:27 ` Simon Horman
2024-02-16 19:47   ` Oliver Hartkopp [this message]
2024-02-19 17:00     ` Simon Horman
2024-02-19 20:37       ` Oliver Hartkopp
2024-02-20 13:40         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12cd0fd0-be86-4af0-8d6b-85d3a81edd2a@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=d.dulov@aladdin.ru \
    --cc=davem@davemloft.net \
    --cc=dev.kurt@vandijck-laurijssen.be \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®