From: <Codrin.Ciubotariu@microchip.com>
To: <andrew@lunn.ch>
Cc: <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>
Subject: Re: [PATCH] net: mdio: of: Do not treat fixed-link as PHY
Date: Wed, 1 Apr 2020 07:50:58 +0000 [thread overview]
Message-ID: <12cdbe77-b932-9194-5d5e-5058622cef6c@microchip.com> (raw)
In-Reply-To: <20200331125908.GB24486@lunn.ch>
On 31.03.2020 15:59, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> Thanks guys. I thought there might be other controllers that have the
>> PHY nodes inside the ethernet node.
>
> Hi Codrin
Hi Andrew
>
> There are some still using this deprecated feature. But macb is the
> only one doing this odd looping over child nodes. It is this looping
> which is breaking things, not the use of the deprecated feature
> itself.
Yes, its due to the fact that the MDIO node is missing. Should we have
in mind to add an MDIO node under the macb node, where we could add the
PHY nodes? The macb bindings don't seem to require the PHY nodes
directly under the macb node, but the compatibility with the deprecated
feature needs to be maintained.
Best regards,
Codrin
next prev parent reply other threads:[~2020-04-01 7:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 16:01 Codrin Ciubotariu
2020-03-30 16:17 ` Andrew Lunn
2020-03-30 16:21 ` Russell King - ARM Linux admin
2020-03-30 16:24 ` Andrew Lunn
2020-03-30 16:30 ` Andrew Lunn
2020-03-30 17:22 ` Florian Fainelli
2020-03-31 8:54 ` Codrin.Ciubotariu
2020-03-31 12:59 ` Andrew Lunn
2020-04-01 7:50 ` Codrin.Ciubotariu [this message]
2020-04-01 13:06 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12cdbe77-b932-9194-5d5e-5058622cef6c@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome