From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1764555AbcINPsD (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 11:48:03 -0400
Received: from nbd.name ([46.4.11.11]:42107 "EHLO nbd.name"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1764050AbcINPsB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 11:48:01 -0400
Subject: Re: [PATCH V2 3/3] net-next: dsa: add new driver for qca8xxx family
To: "David S. Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
References: <1473849542-3298-1-git-send-email-john@phrozen.org>
 <1473849542-3298-4-git-send-email-john@phrozen.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        qsdk-review@qca.qualcomm.com
From: John Crispin <john@phrozen.org>
Message-ID: <12cdce62-b5a4-c423-2532-d86f159d3be6@phrozen.org>
Date: Wed, 14 Sep 2016 17:47:53 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0)
 Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1473849542-3298-4-git-send-email-john@phrozen.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 14/09/2016 12:39, John Crispin wrote:
> +static void
> +qca8k_fdb_add(struct dsa_switch *ds, int port,
> +	      const struct switchdev_obj_port_fdb *fdb,
> +	      struct switchdev_trans *trans)
> +{
> +	struct qca8k_priv *priv = qca8k_to_priv(ds);
> +	u16 port_mask = BIT(port);
> +	u16 vid = fdb->vid;
> +
> +	if (!vid)
> +		vid = 1;
> +
> +	qca8k_fdb_write(priv, vid, port_mask, fdb->addr,
> +			QCA8K_ATU_STATUS_STATIC);
> +
> +	qca8k_fdb_access(priv, QCA8K_FDB_LOAD, -1);
> +}
> +
> +static int
> +qca8k_fdb_del(struct dsa_switch *ds, int port,
> +	      const struct switchdev_obj_port_fdb *fdb)
> +{
> +	struct qca8k_priv *priv = qca8k_to_priv(ds);
> +	u16 port_mask = BIT(port);
> +
> +	qca8k_fdb_write(priv, fdb->vid, port_mask, fdb->addr, 0);
> +
> +	return qca8k_fdb_access(priv, QCA8K_FDB_PURGE, -1);
> +}
> +

while adding MDB support i noticed that

1) the code above is still not properly locked
2) i can unify the FDB and MDB code

i will send a V3 with those 2 changes tomorrow.

	John