From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1578222578 for ; Tue, 25 Nov 2025 14:26:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764080790; cv=none; b=HZEgmlHq3LG7i062yKJPDu/FolSr8SlTMOKjZlnEVpY3JLYRQapv/64ey72gAKDE9DngYL13xSChY8AUehdTm5NGfw0AZjR9j8aAjvgcBLZI/U0HBr5nWBUg9UWuMzCBow1uQCjTDntsfeBwVdOu1wd+Jb9e8ffnPs2xHpe3csw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764080790; c=relaxed/simple; bh=U5u6saZn2iTIpVEynp6gDRuhzzrTr4z4UIohxHUoVDk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=az146jUFgr4TRMifHcVPVoYB8aof665euTPpPBo4RnJU86C3qrn433Fs8RSKuSeg1FrbkAweX5W0FruLEptBJeQW4WATZlFJvlP+rKaJqSYe1vofdjy2kEgYBJeGKKscANNJ9eSz9C5sqDoPshKw3Qx4WZAPgWaUW/3k2/I/Hqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gvuktbP2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=BYh6bBEb; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gvuktbP2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="BYh6bBEb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764080787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U5u6saZn2iTIpVEynp6gDRuhzzrTr4z4UIohxHUoVDk=; b=gvuktbP2m+38dDRqfQlkfxhW+qPScXIaYtoQgtESBSu4LCcJkIYhe+6q5QBBpsG4QeyF/I +vdJ+4EzpJIlI6s3S5AIbP31B47j8Pk1iXC6W7sAbN1zmwz6hWMbx6mNuEujvGhNVbs67Z dJ6/rTqXzFUrPUbs9Yq5Z/8wYFfOCFg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-fV-0aj5BOLK6YtjnoIVGZg-1; Tue, 25 Nov 2025 09:26:26 -0500 X-MC-Unique: fV-0aj5BOLK6YtjnoIVGZg-1 X-Mimecast-MFC-AGG-ID: fV-0aj5BOLK6YtjnoIVGZg_1764080785 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-47799717212so43628385e9.3 for ; Tue, 25 Nov 2025 06:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764080785; x=1764685585; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U5u6saZn2iTIpVEynp6gDRuhzzrTr4z4UIohxHUoVDk=; b=BYh6bBEbPFM8J5DAMYEKVWbOt7U+JC49lvPl9sR2AcRPD5o2uW1l5jF8tC2Ogn5sKc gejaHdRHshYKfxcq/9YjW3lVFE30ZV69zYAg5fyb4552y6d4hdbRtXlCigxEmOCScFyQ VT8kscu2NgWYjlpsibg4PuVqfW1UV+JZFHCg2HP1+arL3qjCtbcuuSiju7Tk6rOFCMbb mMXpT0pHHP3Q4ibyPYHoE+sOuSh/N7uuRuUc1U2XgOBkIiOBPcdAPoGnJPqw6uyEedHq DPQgJZv1R6rZ53JE8ltDZ29GV18M74eXLHQEhD10If0pO1v2srkx5fJpmXVBzhIPtmd7 8c0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764080785; x=1764685585; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U5u6saZn2iTIpVEynp6gDRuhzzrTr4z4UIohxHUoVDk=; b=NRfeyJ7ZixuE5O9NyZis3piaa9O90/ydGzqHInzL8cqpTRhKnYVAJDQjydpHiwtojC pe4PvZoKZaQIhTj5zFCE/lHNrxLTGrZ3/xbRG18bVVfmGWKkoGe4JekB3vjE3Ih0o+7K 1+1V+b/amjPy/5OHNMrxBFQP3nOR//l0RmaWElaAiT9AFZW7bGE8TaX8hz+PD5BGwRQI AOn0PLWn/nHNLjOml4K88WCiAiJnYha+wpgDEwE1YVNkQLuJMZdhL6RL5qY+FNHuRDEj e4Cno2qKNf7097bY5EiO/dANr1wLODeENCwgPaC26Jk124szH9dNI/sdq6dTIxyY4bZs 941Q== X-Forwarded-Encrypted: i=1; AJvYcCVEqLfzQAZfEtT/Qgy0XASUJyEQCrJZkm6BbMKHhedklEdsOSyRKD+ekD9il6T+BbqU1SlbV2AGNfmV8fI=@vger.kernel.org X-Gm-Message-State: AOJu0YxJk2I0KlQNsre7j4zl1I79O89QlhVL5c98u5dqdC/xWqMf6jbf 6APcVO6DmZqhitFAYkpiz67nmOtZis6F+2U00E0k7y8IfLsjkq6n/f+gP1YdqnEddWB2k+cYbNr wP6/4UdU4RUdoYlJE1YeAJ878n/YE5q3IBg7tFBhgwLojbWkt3aGwtBFQKzhDGTKkLg== X-Gm-Gg: ASbGncsOaL0WA80WGJUYKQEttJfxnUKcEektm5wRhp9eIiWxrnPsucP4fp7QQMd9U/w QjF/ByWZqHNvAs3qXwLXZI2+eGFHTb0CXrPtPxWiEDqmmJXkwLn+T5Avy3JFAcWTt0Vr8fjk2YA 3qEEHBfnY5O65jvL8rr4v4HWdk2DVEq7JcEEmzY6PEx9kPij/fxvob5gFhahzTuC3O7G6sguZhY YqZ1oyrBb+xtKVqsRd4TzJuLYMaitpfSRhc7DiXdELhUpRdiNKRkGMMK6X1qhctO1ACT75iyev5 YQcJvlZv7V4GTgX3Ult3qqa+2zCPzUGV77s0KgloWZNgSJne//Eqr5FIXyZCi4wzWUnMdGMPkWe ra67kHOfgus6W0A== X-Received: by 2002:a05:600c:3590:b0:477:54f9:6ac2 with SMTP id 5b1f17b1804b1-477c104fc20mr195497445e9.0.1764080785093; Tue, 25 Nov 2025 06:26:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZaXfPVxOtd161tPfaP0p6wFtwkV3+ZR42m4+eNaUmo7DrGyyx5OQkx0VodjapltytgGteDQ== X-Received: by 2002:a05:600c:3590:b0:477:54f9:6ac2 with SMTP id 5b1f17b1804b1-477c104fc20mr195497055e9.0.1764080784670; Tue, 25 Nov 2025 06:26:24 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.231]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479040a9cf4sm21155365e9.1.2025.11.25.06.26.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 06:26:24 -0800 (PST) Message-ID: <12d4a794-24f4-4201-8671-38851edb7942@redhat.com> Date: Tue, 25 Nov 2025 15:26:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 07/12] ipvlan: Don't allow children to use IPs of main To: Dmitry Skorodumov , netdev@vger.kernel.org, Kuniyuki Iwashima , Xiao Liang , Jakub Kicinski , Julian Vetter , Ido Schimmel , Guillaume Nault , Eric Dumazet , Stanislav Fomichev , Etienne Champetier , linux-kernel@vger.kernel.org Cc: andrey.bokhanko@huawei.com, Andrew Lunn , "David S. Miller" References: <20251120174949.3827500-1-skorodumov.dmitry@huawei.com> <20251120174949.3827500-8-skorodumov.dmitry@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251120174949.3827500-8-skorodumov.dmitry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/20/25 6:49 PM, Dmitry Skorodumov wrote: > Remember all ip-addresses on main iface and check > in ipvlan_addr_busy() that addr is not used on main. Why? Why using in_dev_for_each_ifa_rcu()/in6_dev->addr_list is not good enough? Note that IP addtion on the main interface can race with ipvlan_addr_busy() even with the code you are proposing. /P