From: Markus Elfring <Markus.Elfring@web.de>
To: Yi Wang <wang.yi59@zte.com.cn>,
Liao Pingfang <liao.pingfang@zte.com.cn>,
linux-sh@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Rich Felker <dalias@libc.org>,
Wang Liang <wang.liang82@zte.com.cn>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] sh: sh4: Fix reference count leak in sq_dev_add
Date: Sat, 25 Jul 2020 13:27:56 +0200 [thread overview]
Message-ID: <12d84b44-96c8-ee11-fff8-b1a7ea6b0d7c@web.de> (raw)
> kobject_init_and_add() takes reference even when it fails. If this
> function returns an error, kobject_put() must be called to properly
> clean up the memory associated with the object.
* An imperative wording can be preferred for the change description,
can't it?
* Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next reply other threads:[~2020-07-25 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 11:27 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-25 11:27 Markus Elfring
2020-07-25 0:17 Yi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12d84b44-96c8-ee11-fff8-b1a7ea6b0d7c@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®