From: Vasily Averin <vvs@virtuozzo.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Shakeel Butt <shakeelb@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Roman Gushchin <guro@fb.com>, Uladzislau Rezki <urezki@gmail.com>,
Vlastimil Babka <vbabka@suse.cz>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel@openvz.org
Subject: Re: [PATCH mm v5] memcg: enable memory accounting in __alloc_pages_bulk
Date: Sat, 16 Oct 2021 09:04:07 +0300 [thread overview]
Message-ID: <12d991ba-1702-c648-c4c7-5f9bd507582d@virtuozzo.com> (raw)
In-Reply-To: <20211015143405.b7d54e4afa4ca7b2d57b6140@linux-foundation.org>
On 16.10.2021 00:34, Andrew Morton wrote:
> On Thu, 14 Oct 2021 11:02:57 +0300 Vasily Averin <vvs@virtuozzo.com> wrote:
>
>> Bulk page allocator is used in vmalloc where it can be called
>> with __GFP_ACCOUNT and must charge allocated pages into memory cgroup.
>
> Is this problem serious enough to justify -stable backporting? Some
> words which explaining reasoning for the backport would be helpful.
>
> This patch makes Shakeel's "memcg: page_alloc: skip bulk allocator for
> __GFP_ACCOUNT" unnecessary. Which should we use?
Please use Shakeel's patch.
My patch at least requires review, so at present it should be delayed.
I've submitted it because it may be useful later.
Moreover Currently it have minor issue, function in !MEMCG_KMEM branch
in of memcontrol.h should be declare as static inline.
Thank you,
Vasily Averin
prev parent reply other threads:[~2021-10-16 6:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 8:04 memcg memory accounting in vmalloc is broken Vasily Averin
2021-10-07 8:13 ` Michal Hocko
2021-10-07 8:16 ` Michal Hocko
2021-10-07 8:50 ` Vasily Averin
2021-10-07 10:08 ` Michal Hocko
2021-10-07 10:20 ` Mel Gorman
2021-10-07 14:02 ` Vlastimil Babka
2021-10-07 14:00 ` Vlastimil Babka
2021-10-07 14:09 ` Michal Hocko
2021-10-07 19:33 ` Vasily Averin
2021-10-08 9:23 ` [PATCH memcg] memcg: enable memory accounting in __alloc_pages_bulk Vasily Averin
2021-10-08 17:35 ` Shakeel Butt
2021-10-12 10:18 ` [PATCH mm v2] " Vasily Averin
2021-10-12 13:10 ` Mel Gorman
2021-10-12 13:40 ` Vasily Averin
2021-10-12 14:58 ` [PATCH mm v3] " Vasily Averin
2021-10-12 15:19 ` Shakeel Butt
2021-10-12 15:20 ` Mel Gorman
2021-10-12 15:36 ` Michal Hocko
2021-10-12 16:08 ` Shakeel Butt
2021-10-12 18:24 ` Michal Hocko
2021-10-13 16:41 ` Shakeel Butt
2021-10-13 17:16 ` Michal Hocko
2021-10-13 17:30 ` Shakeel Butt
2021-10-12 18:45 ` Vasily Averin
2021-10-14 8:02 ` [PATCH mm v5] " Vasily Averin
2021-10-15 21:34 ` Andrew Morton
2021-10-16 6:04 ` Vasily Averin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12d991ba-1702-c648-c4c7-5f9bd507582d@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®