From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753188AbdK3QBU (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 11:01:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39880 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753037AbdK3QBS (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 11:01:18 -0500
Subject: Re: [PATCH v3 3/3] virt: Add vboxguest driver for Virtual Box Guest
 integration
To: Philippe Ombredanne <pombredanne@nexb.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Thayer <michael.thayer@oracle.com>,
        "Knut St . Osmundsen" <knut.osmundsen@oracle.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Christoph Hellwig <hch@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20171129155528.16910-1-hdegoede@redhat.com>
 <20171129155528.16910-3-hdegoede@redhat.com>
 <CAOFm3uG40py1mK1QDk0NoN3PWLe8cqgSARkh6GDi974T791NMQ@mail.gmail.com>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <12dea5e7-4fde-467c-32fa-9897b556ee52@redhat.com>
Date: Thu, 30 Nov 2017 17:01:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAOFm3uG40py1mK1QDk0NoN3PWLe8cqgSARkh6GDi974T791NMQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 30 Nov 2017 16:01:18 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 29-11-17 18:10, Philippe Ombredanne wrote:
> On Wed, Nov 29, 2017 at 4:55 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
>> new file mode 100644
>> index 000000000000..631101578c2a
>> --- /dev/null
>> +++ b/drivers/virt/vboxguest/vboxguest_core.c
>> @@ -0,0 +1,1582 @@
>> +/*
>> + * vboxguest core guest-device handling code, VBoxGuest.cpp in upstream svn.
>> + *
>> + * Copyright (C) 2007-2016 Oracle Corporation
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * The contents of this file may alternatively be used under the terms
>> + * of the Common Development and Distribution License Version 1.0
>> + * (CDDL) only, in which case the provisions of the CDDL are applicable
>> + * instead of those of the GPL.
>> + *
>> + * You may elect to license modified versions of this file under the
>> + * terms and conditions of either the GPL or the CDDL or both.
>> + */
> 
> Hans:
> Could it make sense to replace this whole license boilerplate with the
> new SPDX license ids? e.g. use this instead:
> 
>> +// SPDX-License-Identifier: (GPL-2.0 OR CDDL-1.0)
>> +/*
>> + * vboxguest core guest-device handling code, VBoxGuest.cpp in upstream svn.
>> + *
>> + * Copyright (C) 2007-2016 Oracle Corporation
> 
> This would me much more compact and has the same effect. IMHO this
> especially makes sense for new code as we are still cleaning the rest
> of the kernel, so this would avoid extra work to clean this up later.

Yes that is a good idea, thank you.

I've made that change locally and I will post a v4 with this change
right after this mail.

Regards,

Hans